Skip to content

fix: adjust rmcp::model::Meta ref - #11107

Merged
filipkujawa merged 1 commit into
mainfrom
alexhancock/rmcp-model-meta-ref
Aug 10, 2026
Merged

fix: adjust rmcp::model::Meta ref#11107
filipkujawa merged 1 commit into
mainfrom
alexhancock/rmcp-model-meta-ref

Conversation

@alexhancock

@alexhancock alexhancock commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • update the legitimate tool-response sanitization fixture for the locked rmcp 3.0.0 API
  • restore compilation and execution of the regression coverage added by fix(conversation): sanitize nested tool responses #10609
  • preserve coverage for text/image annotations, structured content, and result metadata

Security context

Supersedes duplicate PR #11101 and completes post-merge verification for:

The production sanitizer is already on main; this corrects the metadata constructor in its legitimate-content regression fixture so the covered issues can be verified on current main after merge.

Verification

  • all required GitHub CI checks passed, including Build/Test, MSRV, both TLS backends, format, clippy, schemas, Desktop, and Live Provider Tests
  • the duplicate fix(provider-types): update tool response metadata fixture #11101 branch independently passed cargo fmt --check, 29 focused tool-response tests, the changed-crate build, and all-target clippy

This finding was discovered by Project Loupe.

@filipkujawa
filipkujawa added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 48fb5bf Aug 10, 2026
25 checks passed
@filipkujawa
filipkujawa deleted the alexhancock/rmcp-model-meta-ref branch August 10, 2026 18:49
michaelneale added a commit that referenced this pull request Aug 10, 2026
* origin/main:
  fix(mcp): prune dead notification subscribers (#11032)
  chore: remove the extension and tool count suggestion (#10869)
  feat: compaction in the GDK (#11042)
  fix(provider): retry transient errors on first stream item before ending turn (#10968)
  feat(cli): add /new to start a fresh session without restarting (#10767)
  feat(acp): title new sessions from _meta.sessionTitle (#10712)
  fix: adjust rmcp::model::Meta ref (#11107)
  Skip hook loading and lifecycle events for subagents (#10596)
  Sanitize Unicode tags in Responses output (#10745)
  fix(conversation): sanitize nested tool responses (#10609)
  fix(hints): bound recursive file expansion (#10546)
  fix(providers): drop stale signed thinking blocks after a mid-conversation model switch (#10007)
  fix(desktop): clarify compact cost display (#11093)
  Index messages by (session_id, created_timestamp, id) to stop on-disk sort storms (#10874)
  docs: add tool shim guide covering when to enable, backends, and troubleshooting (#10858)
  fix(deep-link): route extension/session deep links to regular windows not standalone app windows (#10908)
  fix(ui): raise chat input z-index so slash menu appears above loading indicator (#11015)
  fix(ui): support remote working directory for external backend (#10827)
lifeizhou-ap added a commit that referenced this pull request Aug 11, 2026
* main:
  fix(mcp): prune dead notification subscribers (#11032)
  chore: remove the extension and tool count suggestion (#10869)
  feat: compaction in the GDK (#11042)
  fix(provider): retry transient errors on first stream item before ending turn (#10968)
  feat(cli): add /new to start a fresh session without restarting (#10767)
  feat(acp): title new sessions from _meta.sessionTitle (#10712)
  fix: adjust rmcp::model::Meta ref (#11107)
  Skip hook loading and lifecycle events for subagents (#10596)
  Sanitize Unicode tags in Responses output (#10745)
  fix(conversation): sanitize nested tool responses (#10609)
  fix(hints): bound recursive file expansion (#10546)
  fix(providers): drop stale signed thinking blocks after a mid-conversation model switch (#10007)
  fix(desktop): clarify compact cost display (#11093)
  Index messages by (session_id, created_timestamp, id) to stop on-disk sort storms (#10874)
  docs: add tool shim guide covering when to enable, backends, and troubleshooting (#10858)
  fix(deep-link): route extension/session deep links to regular windows not standalone app windows (#10908)
  fix(ui): raise chat input z-index so slash menu appears above loading indicator (#11015)
  fix(ui): support remote working directory for external backend (#10827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants