chore: remove the extension and tool count suggestion - #10869
Merged
filipkujawa merged 1 commit intoAug 10, 2026
Merged
filipkujawa merged 1 commit into
filipkujawa merged 1 commit into
Conversation
The system prompt warned when more than 5 extensions or 50 tools were enabled. Frontier models handle large tool sets fine now, and the threshold was low enough that the warning fired with just the default extensions. Removes the prompt block, the MAX_EXTENSIONS/MAX_TOOLS thresholds and the counting helpers that are now unused. Closes aaif-goose#10841 Signed-off-by: Seydi Charyyev <seydi.charyev@gmail.com>
TheSeydiCharyyev
force-pushed
the
chore/remove-tool-limit-suggestion
branch
from
August 8, 2026 11:26
244e447 to
26942ee
Compare
filipkujawa
approved these changes
Aug 10, 2026
michaelneale
added a commit
that referenced
this pull request
Aug 10, 2026
* origin/main: fix(mcp): prune dead notification subscribers (#11032) chore: remove the extension and tool count suggestion (#10869) feat: compaction in the GDK (#11042) fix(provider): retry transient errors on first stream item before ending turn (#10968) feat(cli): add /new to start a fresh session without restarting (#10767) feat(acp): title new sessions from _meta.sessionTitle (#10712) fix: adjust rmcp::model::Meta ref (#11107) Skip hook loading and lifecycle events for subagents (#10596) Sanitize Unicode tags in Responses output (#10745) fix(conversation): sanitize nested tool responses (#10609) fix(hints): bound recursive file expansion (#10546) fix(providers): drop stale signed thinking blocks after a mid-conversation model switch (#10007) fix(desktop): clarify compact cost display (#11093) Index messages by (session_id, created_timestamp, id) to stop on-disk sort storms (#10874) docs: add tool shim guide covering when to enable, backends, and troubleshooting (#10858) fix(deep-link): route extension/session deep links to regular windows not standalone app windows (#10908) fix(ui): raise chat input z-index so slash menu appears above loading indicator (#11015) fix(ui): support remote working directory for external backend (#10827)
lifeizhou-ap
added a commit
that referenced
this pull request
Aug 11, 2026
* main: fix(mcp): prune dead notification subscribers (#11032) chore: remove the extension and tool count suggestion (#10869) feat: compaction in the GDK (#11042) fix(provider): retry transient errors on first stream item before ending turn (#10968) feat(cli): add /new to start a fresh session without restarting (#10767) feat(acp): title new sessions from _meta.sessionTitle (#10712) fix: adjust rmcp::model::Meta ref (#11107) Skip hook loading and lifecycle events for subagents (#10596) Sanitize Unicode tags in Responses output (#10745) fix(conversation): sanitize nested tool responses (#10609) fix(hints): bound recursive file expansion (#10546) fix(providers): drop stale signed thinking blocks after a mid-conversation model switch (#10007) fix(desktop): clarify compact cost display (#11093) Index messages by (session_id, created_timestamp, id) to stop on-disk sort storms (#10874) docs: add tool shim guide covering when to enable, backends, and troubleshooting (#10858) fix(deep-link): route extension/session deep links to regular windows not standalone app windows (#10908) fix(ui): raise chat input z-index so slash menu appears above loading indicator (#11015) fix(ui): support remote working directory for external backend (#10827)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10841.
The system prompt appended a
# Suggestionblock when the user had more than 5 extensions or 50 tools enabled, asking the model to suggest disabling some. As noted in the issue, frontier models handle large tool sets fine now, and the threshold was low enough that the block fired with just the default extensions we ship.Removes the prompt block together with everything that fed it: the
MAX_EXTENSIONS/MAX_TOOLSthresholds, theextension_tool_limitscontext field,with_extension_and_tool_counts, and the two counting helpers (total_extension_and_tool_counts,get_extension_and_tool_counts) that no other caller uses.Three snapshots are updated:
typical_setuploses the suggestion block,basicandone_extensionlose the blank line the template block left behind.Testing
Verified on Windows only, against the
x86_64-pc-windows-gnutarget — CI will be the first run on msvc and Linux.cargo test -p goose --lib prompt_manager— 11 passed, 1 failed, which is the same result as on an unmodified tree.test_all_platform_extensions, and it already fails on a clean checkout on Windows: the prompt there substitutesfindstr/Get-Contentfor the unix commands, so the snapshot recorded on Linux cannot match. I left that snapshot untouched.cargo fmt --check— clean.cargo clippy -p goose --all-targets— no new warnings. The few that do appear are pre-existing#[cfg(unix)]artifacts on Windows and are unrelated to this change.