fix(anthropic): add claude-sonnet-5 and claude-fable-5 to known models list - #10865
Merged
DOsinga merged 3 commits intoAug 3, 2026
Merged
Conversation
added 2 commits
July 31, 2026 18:24
Resolves aaif-goose#10864 These models already exist in the bundled canonical registry but were missing from ANTHROPIC_KNOWN_MODELS, so the pre-key model picker could not show them. Mirror the Cursor known-list chore (aaif-goose#10618). Tests: unit coverage for list membership + ProviderMetadata surface.
angiejones
reviewed
Aug 2, 2026
| .format_options(format_options)) | ||
| } | ||
|
|
||
| #[cfg(test)] |
Collaborator
There was a problem hiding this comment.
these tests aren't necessary. please remove
angiejones
reviewed
Aug 2, 2026
| pub const ANTHROPIC_DEFAULT_FAST_MODEL: &str = "claude-haiku-4-5"; | ||
| const ANTHROPIC_KNOWN_MODELS: &[&str] = &[ | ||
| "claude-opus-5", | ||
| // Claude 5 family — pre-key picker (registry already has these; list was lagging) |
angiejones
requested changes
Aug 2, 2026
Address angiejones review on aaif-goose#10865: list membership tests were tautological for a static list add; keep the two model entries only.
Contributor
Author
|
Addressed review feedback:
List still adds |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3decde3268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DOsinga
approved these changes
Aug 3, 2026
michaelneale
added a commit
that referenced
this pull request
Aug 4, 2026
* origin/main: (42 commits) chore (codex-acp): migrate to @agentclientprotocol/codex-acp (#10923) style: add dark mode inline code styling for message bubbles (#10861) docs: clarify macOS sandbox feature was removed in post-v1.25.0 cleanup (#10900) fall back to static model list only for non-models payloads (#10189) Remove CLI project support (#10838) fix(anthropic): add claude-sonnet-5 and claude-fable-5 to known models list (#10865) fix: stdio extensions silently skipped when name missing or env: used in config (#10773) feat(desktop): show session metadata on sidebar chat hover (#10663) fix(serve): start scheduler at startup instead of first ACP connection (#10766) fix: respect disabled builtin extensions (developer) at session start (#10223) fix: parse PyPI requirements for OSV checks (#10510) fix(telegram): contain voice file extensions (#10456) Revert "feat(security): chunk command-classifier input with overlapping windows" (#10416) (#10870) docs: update Discord invite (#10863) fix(security): preserve denied tool request precedence (#10612) fix(hints): contain subdirectory hint discovery (#10545) chore(deps): bump pem from 3.0.6 to 4.0.0 (#10853) chore(deps): bump base64 from 0.22.1 to 0.23.0 (#10851) chore(deps): bump jsonwebtoken from 10.4.0 to 11.0.0 (#10850) chore(deps): bump astral-sh/setup-uv from 8.3.2 to 9.0.0 (#10847) ...
alexhancock
added a commit
that referenced
this pull request
Aug 4, 2026
* origin/main: (58 commits) Handle MCP tool list change notifications fix: restore final_output_tool when agent is recreated after LRU eviction (#10793) feat(ui): bring back make sidebar resizable with drag handle and persisted width (#10795) docs: document auto-injected GOOSE_SHELL flags (#10759) feat: surface output-token-limit info (#10831) fix(desktop): avoid O(n²) cloning during session load (#10665) feat: add interactive menu for single select elicitations (#10327) fix(acp): prefix child stderr log target so it passes the default goose=info filter (#10901) chore (codex-acp): migrate to @agentclientprotocol/codex-acp (#10923) style: add dark mode inline code styling for message bubbles (#10861) docs: clarify macOS sandbox feature was removed in post-v1.25.0 cleanup (#10900) fall back to static model list only for non-models payloads (#10189) Remove CLI project support (#10838) fix(anthropic): add claude-sonnet-5 and claude-fable-5 to known models list (#10865) fix: stdio extensions silently skipped when name missing or env: used in config (#10773) feat(desktop): show session metadata on sidebar chat hover (#10663) fix(serve): start scheduler at startup instead of first ACP connection (#10766) fix: respect disabled builtin extensions (developer) at session start (#10223) fix: parse PyPI requirements for OSV checks (#10510) fix(telegram): contain voice file extensions (#10456) ... # Conflicts: # Cargo.lock # crates/goose/src/agents/extension_manager.rs # crates/goose/tests/mcp_replays/npx-y@modelcontextprotocol_server-everything@2026.1.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10864
Summary
claude-sonnet-5andclaude-fable-5toANTHROPIC_KNOWN_MODELS(pre-key picker /ProviderMetadata)claude-opus-5regression)Test plan
cargo test -p goose-providers known_models(3 new tests)cargo test -p goose-providers— 114 passedcargo clippy -p goose-providers --all-targets -- -D warnings— cleancargo test -p goose-provider-types map_to_canonical_model— ok (registry already mapsanthropic/claude-sonnet-5)Out of scope
recommended_models_from_registry(noted on the issue as a durable follow-up)