Skip to content

fix(config): preserve enabled flag when migrating platform extensions #10690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 1 commit into from
Jul 27, 2026
+9 −3
Merged

fix(config): preserve enabled flag when migrating platform extensions #10690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions crates/goose/src/config/migrations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ pub fn run_read_migrations(config: &mut Mapping) {
migrate_platform_extensions(config);
}

fn read_enabled_field(value: &serde_yaml::Value) -> Option<bool> {
value
.as_mapping()?
.get(serde_yaml::Value::String("enabled".to_string()))?
.as_bool()
}

fn migrate_platform_extensions(config: &mut Mapping) -> bool {
let extensions_key = serde_yaml::Value::String(EXTENSIONS_CONFIG_KEY.to_string());

Expand Down Expand Up @@ -68,9 +75,8 @@ fn migrate_platform_extensions(config: &mut Mapping) -> bool {
let existing_entry =
existing.and_then(|v| serde_yaml::from_value::<ExtensionEntry>(v.clone()).ok());

let enabled = existing_entry
.as_ref()
.map(|e| e.enabled)
let enabled = existing
.and_then(read_enabled_field)
.unwrap_or(def.default_enabled);

// If the extension already exists as type 'builtin', preserve that type
Expand Down