fix(i18n): fix Korean translation errors, untranslated entries, and terminology consistency - #10667
Conversation
…erminology consistency ## Summary Fixed 120 Korean translation entries in ui/desktop/src/i18n/messages/ko.json covering: - 16 untranslated entries → translated to Korean - 10 meaning-mismatched translations aligned to English source - 16 Goose → goose lowercase per branding guidelines (except role label) - 3 cron picker prepositions differentiated (at→시각, in→월, on→지정) - 5 loading messages changed to polite -요 style - 19 terminology consistency fixes (크론→cron, 감지→탐지, 호환 가능→호환, 서브레시피 유지) - 17 spacing fixes (변경사항→변경 사항, 일시중지→일시 중지, 괄호 앞 띄어쓰기) - 4 placeholder values kept in English (input format examples) - 18 expression/grammar fixes (사용자화→맞춤 설정, 좋아요→확인, 초점→포커스) ### Testing - pnpm i18n:validate-locale ko — passed (1536 messages) - pnpm typecheck — passed
8f967a0 to
efddef4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f967a035b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "cronPicker.inMonth": { | ||
| "defaultMessage": "에" | ||
| "defaultMessage": "월" |
There was a problem hiding this comment.
For Korean users configuring a yearly schedule, this string is rendered immediately before the month dropdown in CronPicker.tsx; the options are already translated as 1월, 2월, etc., so the UI now reads like 월 1월 instead of conveying “in January.” This makes the schedule sentence harder to interpret and can lead users to misread which part of the cron expression they are editing; use a phrase/particle that works before the selector rather than the noun 월.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch. We decided to keep the cron picker labels and options in English since cron expressions are inherently English-based. This avoids the "월 1월" duplication issue and maintains consistency across all period modes.
* origin/main: (24 commits) upgrade to rmcp 2.0 (#10584) chore: opus5 support (including adaptive thinking) (#10686) fix(desktop): use shell working directory on initial launch (#10655) fix(providers): enable inventory refresh for OpenRouter model picker (#10641) Add configurable GOOSE_DOCS_ROOT for air-gapped docs access (#10294) fix(i18n): fix Korean translation errors, untranslated entries, and terminology consistency (#10667) fix(acp): preserve read lines and reload tool output (#10662) fix(acp): surface tool call output in CLI and Desktop (#10654) fix overlong function names in provider requests (#10659) fix (desktop): preserve ACP tool call update fields (#10653) feat: support latest Gemini models (#10630) Merge commit from fork feat (acp): Gate tool-call label enrichment on ACP client capability (#10644) fix(session): use configured session manager for tool summaries (#10628) refactor (acp): simplify ACP tool-call handling and fix chain summaries (#10599) fix: omit disabled OpenRouter reasoning (#10517) enhance the uniffi API layer (#10427) remove sampling from smoke test (#10639) rebuild canonical model db (#10633) fix(ui): clear stale pending ACP connection after terminal recovery failure (#10552) ... # Conflicts: # ui/desktop/src/i18n/messages/ko.json
2 participants
Summary
Fixed 120 Korean translation entries in
ui/desktop/src/i18n/messages/ko.jsoncovering:chatSettings.modeDescriptionhad completely different meaning,externalBackendSection.*lost ACP references)sessionViewComponents.role.assistantwhich keeps "Goose" as a role label)Testing
pnpm i18n:validate-locale ko— passed (1536 messages, structure + ICU placeholder validation)pnpm typecheck— passed