Skip to content

remove sampling from smoke test - #10639

Merged
jamadeo merged 1 commit into
mainfrom
sampling-smoke-test
Jul 22, 2026
Merged

remove sampling from smoke test#10639
jamadeo merged 1 commit into
mainfrom
sampling-smoke-test

Conversation

@jamadeo

@jamadeo jamadeo commented Jul 22, 2026

Copy link
Copy Markdown
Member

This test is pretty flaky. We could fix it, but sampling is deprecated in the new MCP spec, so it seems not worth it.

@DOsinga DOsinga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah!

@jamadeo
jamadeo added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit f0fecbc Jul 22, 2026
23 checks passed
@jamadeo
jamadeo deleted the sampling-smoke-test branch July 22, 2026 18:19
alexhancock added a commit that referenced this pull request Jul 27, 2026
* origin/main: (24 commits)
  upgrade to rmcp 2.0 (#10584)
  chore: opus5 support (including adaptive thinking) (#10686)
  fix(desktop): use shell working directory on initial launch (#10655)
  fix(providers): enable inventory refresh for OpenRouter model picker (#10641)
  Add configurable GOOSE_DOCS_ROOT for air-gapped docs access (#10294)
  fix(i18n): fix Korean translation errors, untranslated entries, and terminology consistency (#10667)
  fix(acp): preserve read lines and reload tool output (#10662)
  fix(acp): surface tool call output in CLI and Desktop (#10654)
  fix overlong function names in provider requests (#10659)
  fix (desktop): preserve ACP tool call update fields (#10653)
  feat: support latest Gemini models (#10630)
  Merge commit from fork
  feat (acp): Gate tool-call label enrichment on ACP client capability (#10644)
  fix(session): use configured session manager for tool summaries (#10628)
  refactor (acp): simplify ACP tool-call handling and fix chain summaries (#10599)
  fix: omit disabled OpenRouter reasoning (#10517)
  enhance the uniffi API layer (#10427)
  remove sampling from smoke test (#10639)
  rebuild canonical model db (#10633)
  fix(ui): clear stale pending ACP connection after terminal recovery failure (#10552)
  ...

# Conflicts:
#	ui/desktop/src/i18n/messages/ko.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants