Skip to content

fix: isolate prepare tools test state #10504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifeizhou-ap merged 1 commit into from
Jul 16, 2026
Merged

fix: isolate prepare tools test state #10504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions crates/goose/src/agents/reply_parts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,10 +666,11 @@ pub fn is_tool_visible_to_model(tool: &Tool) -> bool {
#[cfg(test)]
mod tests {
use super::*;
use crate::config::GooseMode;
use crate::agents::{AgentConfig, GoosePlatform};
use crate::config::{GooseMode, PermissionManager};
use crate::conversation::message::{Message, SystemNotificationType};
use crate::providers::base::Provider;
use crate::session::session_manager::SessionType;
use crate::session::{SessionManager, SessionType};
use async_trait::async_trait;
use goose_providers::conversation::token_usage::{ProviderStats, ProviderUsage, Usage};
use goose_providers::model::ModelConfig;
Expand Down Expand Up @@ -700,11 +701,19 @@ mod tests {

#[tokio::test]
async fn prepare_tools_returns_sorted_tools_including_frontend() -> anyhow::Result<()> {
let agent = crate::agents::Agent::new();
let data_dir = tempfile::tempdir()?;
let data_path = data_dir.path().to_path_buf();
let session_manager = std::sync::Arc::new(SessionManager::new(data_path.clone()));
let agent = Agent::with_config(AgentConfig::new(
std::sync::Arc::clone(&session_manager),
std::sync::Arc::new(PermissionManager::new(data_path)),
None,
GooseMode::default(),
false,
GoosePlatform::GooseCli,
));

let session = agent
.config
.session_manager
let session = session_manager
.create_session(
std::env::current_dir().unwrap(),
"test-prepare-tools".to_string(),
Expand Down