fix: isolate prepare tools test state - #10504
Merged
Merged
Conversation
lifeizhou-ap
marked this pull request as ready for review
July 16, 2026 06:36
michaelneale
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare_tools_returns_sorted_tools_including_frontendisolated temporary session and permission storageAgent::new()Root cause
The test created its session through the global
SessionManager. Parallel tests temporarily changeGOOSE_PATH_ROOT, so the lazy global SQLite pool could be initialized inside a temporary directory that was deleted before this test openedsessions.db. This produced SQLite error 14 (unable to open database file) in the native-TLS CI job.Testing
cargo fmt --checkcargo test -p goose --no-default-features --features native-tls,code-mode agents::reply_parts::tests::prepare_tools_returns_sorted_tools_including_frontend -- --exactcargo test -p goose --no-default-features --features native-tls,code-mode --lib— the fixed test passed in the parallel suite; 1394 tests passed and four unrelated local environment-sensitive plugin discovery/Ollama tests failed