ci: drop non-existent goose-server crate from TLS matrix job - #10465
Merged
Conversation
alexhancock
force-pushed
the
fix/tls-ci-remove-goose-server
branch
from
July 14, 2026 18:08
df82b8f to
4f8bde3
Compare
Abhijay007
approved these changes
Jul 14, 2026
Abhijay007
enabled auto-merge
July 14, 2026 18:09
AgarwalManas
added a commit
to AgarwalManas/goose
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
rust-build-and-test-tlsjob added in #10148 fails with:(e.g. https://github.com/aaif-goose/goose/actions/runs/29354955233/job/87160196883)
Root cause
The job runs:
but there is no
goose-servercrate in this workspace. The members aregoose,goose-cli,goose-providers,goose-mcp, etc. Passing--featuresfor a package that isn't a workspace member makes cargo error out, breaking both therustls-tlsandnative-tlsmatrix builds.Fix
Minimal change — remove the single invalid line. The remaining targets (
goose,goose-providers,goose-cli) are real workspace members and resolve features correctly for both TLS backends (verified locally with--no-run).Note
Because
goose-servernever existed in this workspace, the server-side code was never actually being exercised by this matrix. If server/HTTP coverage under the TLS matrix is desired, that should be a follow-up pointing at the correct crate.