ci: add TLS backend matrix job for rustls-tls and native-tls - #10148
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f75b590d5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I will finish this at some point this week. I opened it quite late yesterday, and couldn't really pay much attention to the test. |
Add a new CI job that builds and tests goose with both TLS feature flags. Runs in parallel with fail-fast disabled so both backends are validated on every PR.
f75b590 to
b21caa9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b21caa9f12
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Scenario tests (scenario_tests::scenarios::tests) live in goose-cli, not goose — switch those two commands to -p goose-cli so they actually execute. - goose-server owns the TLS wiring tested in tls_test.rs; add a goose-server test step so both native-tls and rustls-tls are validated against the server package on every matrix leg.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1d069fd7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
When session.model_config is None, maybe_update_name falls back to Config::global().get_goose_model(). In the TLS matrix CI job the tests run in a different order/parallelism than the regular suite, so the global config is not initialised by the time this test executes — causing it to panic with "missing model". Fix: set a ModelConfig directly on the session before calling maybe_update_name, so the test never reaches the Config::global() path. The NamingTestProvider ignores the model config anyway.
3 participants
Summary
Add a new CI job that builds and tests goose with both TLS feature flags. Runs in parallel with fail-fast disabled so both backends are validated on every PR.
Testing
Testing in this pull request.
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: