fix(ui): restore pnpm 11 project configuration - #10395
Merged
Merged
Conversation
Move settings to the workspace file so both pnpm 10.30 and 11 apply the same install policy from nested packages. Constraint: Goose supports pnpm >=10.30.0 while pnpm 11 no longer reads package.json#pnpm. Rejected: Keep linker settings in ui/.npmrc | pnpm 11 does not discover that file from ui/desktop. Confidence: high Scope-risk: narrow Directive: Keep project-scoped pnpm settings in pnpm-workspace.yaml for nested package installs. Tested: Frozen lockfile-only installs on pnpm 11.11.0 and 10.30.3; project config visibility; package JSON formatting; diff checks. Not-tested: Full lifecycle scripts; the container exhausted disk extracting platform binaries after resolving 1505/1506 packages.
alexhancock
approved these changes
Jul 13, 2026
afternoon
added a commit
to afternoon/goose
that referenced
this pull request
Jul 13, 2026
- feat: allow askai bot to read issues and PRs (aaif-goose#10398) - fix: Fix Gemini OAuth onboarding (aaif-goose#10363) - chore: remove unavailable models from cerebras catalog (aaif-goose#10407) - feat(cli): Fix output.rs merge conflicts - chore(deps): bump actions/stale from 10.3.0 to 10.4.0 (aaif-goose#10371) - chore(deps): bump dorny/paths-filter from 4.0.1 to 4.0.2 (aaif-goose#10370) - chore(deps): bump actions/cache from 6.0.0 to 6.1.0 (aaif-goose#10374) - fix: treat empty-string finish_reason as non-terminal in streaming (aaif-goose#10258) - chore(deps): bump step-security/harden-runner from 2.19.4 to 2.20.0 (aaif-goose#10372) - chore(deps): bump docker/login-action from 4.2.0 to 4.4.0 (aaif-goose#10373) - test: drop unavailable and preview Gemini smoke models (aaif-goose#10355) - fix(ui): restore pnpm 11 project configuration (aaif-goose#10395) - Fix/compact disabled during approval (aaif-goose#10089) - fix(prompt): make prompt timestamps timezone-explicit (aaif-goose#10209) - fix: preserve reasoning_content for DeepSeek thinking mode on multi-turn tool calls (aaif-goose#10366) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-workspace.yaml, where pnpm 11 reads themonlyBuiltDependencieswithallowBuildsand permit Electron Forge's pinned git subdependencyTesting
pnpm install --lockfile-only --frozen-lockfilewith pnpm 11.11.0corepack pnpm@10.30.3 install --lockfile-only --frozen-lockfilepnpm config list --location projectfromui/desktoppnpm dlx prettier@3.8.1 --check ui/package.jsongit diff --checkA full pnpm 11 install cleared the reported configuration errors and reached package linking, but this container ran out of disk while extracting platform binaries.
Related Issues
Fixes #10382
Screenshots/Demos
Not applicable.