fix: Fix Gemini OAuth onboarding - #10363
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e1a7d0c48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| console.error('Failed to finish local model setup:', error); | ||
| setErrorMessage(formatErrorMessage(error)); | ||
| trackOnboardingSetupFailed(LOCAL_PROVIDER, 'save_defaults_failed'); | ||
| setPhase('error'); |
There was a problem hiding this comment.
When onConfigured rejects after a newly downloaded model completes, this error path leaves models with the pre-download status. The Try Again button only switches back to select, so handlePrimaryAction still sees the selected model as not downloaded and starts another download instead of retrying the defaults save; this affects transient save failures or races where the backend has not registered the just-downloaded local model yet.
Useful? React with 👍 / 👎.
- feat: allow askai bot to read issues and PRs (aaif-goose#10398) - fix: Fix Gemini OAuth onboarding (aaif-goose#10363) - chore: remove unavailable models from cerebras catalog (aaif-goose#10407) - feat(cli): Fix output.rs merge conflicts - chore(deps): bump actions/stale from 10.3.0 to 10.4.0 (aaif-goose#10371) - chore(deps): bump dorny/paths-filter from 4.0.1 to 4.0.2 (aaif-goose#10370) - chore(deps): bump actions/cache from 6.0.0 to 6.1.0 (aaif-goose#10374) - fix: treat empty-string finish_reason as non-terminal in streaming (aaif-goose#10258) - chore(deps): bump step-security/harden-runner from 2.19.4 to 2.20.0 (aaif-goose#10372) - chore(deps): bump docker/login-action from 4.2.0 to 4.4.0 (aaif-goose#10373) - test: drop unavailable and preview Gemini smoke models (aaif-goose#10355) - fix(ui): restore pnpm 11 project configuration (aaif-goose#10395) - Fix/compact disabled during approval (aaif-goose#10089) - fix(prompt): make prompt timestamps timezone-explicit (aaif-goose#10209) - fix: preserve reasoning_content for DeepSeek thinking mode on multi-turn tool calls (aaif-goose#10366) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 participants
Summary
Fixes #10322
Testing
Unit testing and manual
Related Issues
Relates to #10322