Disable thinking preservation for Groq - #10284
Merged
Merged
Conversation
angiejones
enabled auto-merge
July 6, 2026 01:24
The-Best-Codes
approved these changes
Jul 6, 2026
ellenblaine
added a commit
to ellenblaine/goose
that referenced
this pull request
Jul 7, 2026
…mestamp-timezone * origin/main: (34 commits) feat: askai bot hints for followups (aaif-goose#10291) feat(desktop): per-message usage stats UI (tokens, cost, TTFT, tok/s) (aaif-goose#10210) fix(server): return effective context limit from /model-info (aaif-goose#10165) fix(deps): gate rcgen aws_lc_rs feature behind rustls-tls (aaif-goose#10116) Disable thinking preservation for Groq (aaif-goose#10284) Bound code-mode execution with timeout and cancellation (aaif-goose#10214) chore(deps): bump docker/setup-buildx-action from 4.1.0 to 4.2.0 (aaif-goose#10232) chore(deps): bump docker/build-push-action from 7.2.0 to 7.3.0 (aaif-goose#10233) chore(deps): bump docker/metadata-action from 6.1.0 to 6.2.0 (aaif-goose#10235) chore(deps): bump mockall from 0.14.0 to 0.15.0 (aaif-goose#10240) chore(deps): bump uniffi from 0.31.1 to 0.32.0 (aaif-goose#10247) chore(deps): bump sigstore-verify from 0.9.0 to 0.10.0 (aaif-goose#10250) chore(deps): bump cmov from 0.5.3 to 0.5.4 (aaif-goose#10282) chore(deps): bump candle-transformers from 0.10.2 to 0.11.0 (aaif-goose#10242) chore(deps): bump candle-core from 0.10.2 to 0.11.0 (aaif-goose#10241) fix: recover malformed tool calls from GLM/Minimax models instead of rejecting them (aaif-goose#10230) chore(deps): bump jsonschema from 0.30.0 to 0.46.9 (aaif-goose#10244) move google provider into goose-providers (aaif-goose#10216) chore(deps): bump umya-spreadsheet from 2.3.3 to 3.0.0 (aaif-goose#10248) add provider bindings MVP to goose-sdk, and add python wheel publishing (aaif-goose#10208) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable thinking preservation for Groq to avoid sending unsupported
reasoning_contentfields.Testing
cargo fmt --checkcargo test -p goose-providers groq_json_disables_thinking_preservationcargo test -p goose-providers from_json_defaults_openai_preserves_thinking_to_trueRelated Issues
Resolves #10200
Screenshots/Demos (for UX changes)
Before:
After: