Skip to content

add provider bindings MVP to goose-sdk, and add python wheel publishing - #10208

Merged
jamadeo merged 19 commits into
mainfrom
providers-crate-publishing
Jul 6, 2026
Merged

add provider bindings MVP to goose-sdk, and add python wheel publishing#10208
jamadeo merged 19 commits into
mainfrom
providers-crate-publishing

Conversation

@jamadeo

@jamadeo jamadeo commented Jul 2, 2026

Copy link
Copy Markdown
Member
  • adds a minimal binding for the provider crate with client code generated for kotlin and python
  • sets versions in crates for publishing
  • adds justfile targets for publishing crates and wheels

for #9803

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af9e6e1cfe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose-sdk/justfile Outdated
Comment thread crates/goose-providers/Cargo.toml Outdated
Comment thread crates/goose-sdk/justfile Outdated
@jamadeo jamadeo closed this Jul 2, 2026
@jamadeo jamadeo reopened this Jul 2, 2026
@jamadeo
jamadeo changed the base branch from provider-bindings to main July 2, 2026 21:06
@jamadeo jamadeo changed the title [don't merge until base merges] Providers crate publishing add provider bindings MVP to goose-sdk, and add python wheel publishing Jul 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4056a05e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose-providers/Cargo.toml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a74fa02698

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose-sdk/justfile
goose-provider-types \
goose-sdk-types \
goose-download-manager \
goose-local-inference \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Skip unpublishable local-inference in publish loop

Fresh evidence beyond the earlier path-dependency report: on this tree cargo package -p goose-local-inference --allow-dirty --no-verify now fails because Cargo strips git sources and the optional mlx-lm/mlx-lm-utils dependencies have no registry versions. Since this recipe publishes goose-local-inference before goose-providers/goose-sdk, crates-publish stops here and the SDK release cannot proceed until that crate is made publishable or excluded from this publish chain.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to update the git dependencies before this will work

Comment thread .github/workflows/python-sdk-wheels.yml Fixed
Comment thread .github/workflows/python-sdk-wheels.yml Fixed
Comment thread .github/workflows/python-sdk-wheels.yml Fixed
Comment thread .github/workflows/python-sdk-wheels.yml Fixed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e6bfb095e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

os: macos-14
- name: macos-x86_64
os: macos-13
- name: linux-x86_64

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Build Linux wheels with a manylinux tag

When this new Linux matrix entry runs, python-wheel builds the binary wheel directly on ubuntu-latest, and setup.py preserves bdist_wheel's host platform tag, producing a *-linux_x86_64.whl. PyPI rejects Linux binary wheels with that unsupported platform tag unless they are built/repaired as manylinux or musllinux, so the publish job will fail or partially publish whenever publish=true includes this artifact.

Useful? React with 👍 / 👎.

@DOsinga DOsinga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on core-team ownership; Jack will follow through on the remaining packaging/publishing details.

@jamadeo
jamadeo added this pull request to the merge queue Jul 6, 2026
Merged via the queue into main with commit 140158c Jul 6, 2026
29 of 31 checks passed
@jamadeo
jamadeo deleted the providers-crate-publishing branch July 6, 2026 01:31
ellenblaine added a commit to ellenblaine/goose that referenced this pull request Jul 7, 2026
…mestamp-timezone

* origin/main: (34 commits)
  feat: askai bot hints for followups (aaif-goose#10291)
  feat(desktop): per-message usage stats UI (tokens, cost, TTFT, tok/s) (aaif-goose#10210)
  fix(server): return effective context limit from /model-info (aaif-goose#10165)
  fix(deps): gate rcgen aws_lc_rs feature behind rustls-tls (aaif-goose#10116)
  Disable thinking preservation for Groq (aaif-goose#10284)
  Bound code-mode execution with timeout and cancellation (aaif-goose#10214)
  chore(deps): bump docker/setup-buildx-action from 4.1.0 to 4.2.0 (aaif-goose#10232)
  chore(deps): bump docker/build-push-action from 7.2.0 to 7.3.0 (aaif-goose#10233)
  chore(deps): bump docker/metadata-action from 6.1.0 to 6.2.0 (aaif-goose#10235)
  chore(deps): bump mockall from 0.14.0 to 0.15.0 (aaif-goose#10240)
  chore(deps): bump uniffi from 0.31.1 to 0.32.0 (aaif-goose#10247)
  chore(deps): bump sigstore-verify from 0.9.0 to 0.10.0 (aaif-goose#10250)
  chore(deps): bump cmov from 0.5.3 to 0.5.4 (aaif-goose#10282)
  chore(deps): bump candle-transformers from 0.10.2 to 0.11.0 (aaif-goose#10242)
  chore(deps): bump candle-core from 0.10.2 to 0.11.0 (aaif-goose#10241)
  fix: recover malformed tool calls from GLM/Minimax models instead of rejecting them (aaif-goose#10230)
  chore(deps): bump jsonschema from 0.30.0 to 0.46.9 (aaif-goose#10244)
  move google provider into goose-providers (aaif-goose#10216)
  chore(deps): bump umya-spreadsheet from 2.3.3 to 3.0.0 (aaif-goose#10248)
  add provider bindings MVP to goose-sdk, and add python wheel publishing (aaif-goose#10208)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants