fix(desktop): seed mac auto-update config - #10132
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 799cb99b48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| omitPrereleaseDuringUpdate: true | ||
|
|
||
| - name: Upload macOS update manifest | ||
| if: ${{ vars.ENABLE_MAC_NATIVE_AUTO_UPDATE == 'true' }} |
There was a problem hiding this comment.
When ENABLE_MAC_NATIVE_AUTO_UPDATE is false, this upload step is skipped, but the Release stable action above only updates assets and does not remove unlisted ones; I checked the pinned ncipollo/release-action docs and removeArtifacts defaults to false. Since prior stable releases uploaded latest-mac.yml, the old manifest remains attached to the stable release, so existing mac clients still fetch a native-update manifest instead of getting the 404 needed to exercise the fallback zip flow. Please explicitly delete latest-mac.yml from stable (and same-tag reruns, if relevant) in the disabled path.
Useful? React with 👍 / 👎.
|
Thanks for this PR! I think the safe rollout could be:
And we don't need ENABLE_MAC_NATIVE_AUTO_UPDATE |
| merge-multiple: true | ||
|
|
||
| - name: Generate macOS update manifest | ||
| if: ${{ vars.ENABLE_MAC_NATIVE_AUTO_UPDATE == 'true' }} |
There was a problem hiding this comment.
where is ENABLE_MAC_NATIVE_AUTO_UPDATE var defined and where to set the value?
799cb99 to
219f027
Compare
|
Addressed in the latest push. The release workflow now defines |
* main: fix: tolerate partial Responses output items (#10108) fix(databricks): always use OpenAI-compatible "parameters" for tools (#10101) fix(providers): unescape shell-escaped image paths (#10098) chore(deps-dev): bump js-yaml from 4.1.1 to 4.2.0 in /documentation (#10107) regenerate schema (#10166) chore(deps): bump actions/stale from 10.1.1 to 10.3.0 (#10050) chore(deps): bump actions/attest-build-provenance from 4.1.0 to 4.1.1 (#10049) chore(deps): bump pnpm/action-setup from 6.0.8 to 6.0.9 (#9892) Update EmpirioLabs provider display name to EmpirioLabs AI (#10126) add declarative provider support to goose-providers crate (#9992) fix(desktop): seed mac auto-update config (#10132) Update release testing instructions (#10122)
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
2 participants
Summary
app-update.ymlinto the Electron resources root soelectron-updatercan complete native mac downloadslatest-mac.ymlrelease publication behindENABLE_MAC_NATIVE_AUTO_UPDATEso existing 1.38/1.39 installs keep using the fallback zip flow until a config-seeded release is installedRollout note
Do not enable
ENABLE_MAC_NATIVE_AUTO_UPDATEfor the immediate next release. Existing installed apps do not haveapp-update.yml, so they must first update through the fallback zip/manual flow to a build that contains this file. Native mac metadata can be enabled for a later release once the installed base has the packaged config.Verification
node ui/desktop/scripts/verify-mac-update-resources.js <fake-app>pnpm exec prettier --check forge.config.ts scripts/verify-mac-update-resources.js src/app-update.ymljs-yamlnode -e "const cfg=require('./ui/desktop/forge.config.ts'); if (!cfg.packagerConfig.extraResource.includes('src/app-update.yml')) process.exit(1)"@aaif/goose-sdklocally, thenpnpm run packagenode scripts/verify-mac-update-resources.js out/Goose-darwin-arm64/Goose.app