fix(databricks): always use OpenAI-compatible "parameters" for tools - #10101
Merged
DOsinga merged 1 commit intoJul 1, 2026
Merged
Conversation
Databricks serving endpoints — including Gemini-backed ones — speak the OpenAI-compatible chat format, so tool definitions must use the "parameters" field, not Google's native "parametersJsonSchema". The previous is_gemini branch emitted "parametersJsonSchema" for any model name containing "gemini" (e.g. databricks-gemini-3-pro), which the endpoint rejects. Drop the is_gemini branch so all Databricks tools use "parameters", and update the format_tools test to assert the OpenAI-compatible shape. Split out of aaif-goose#9906 per review feedback as a self-contained fix.
DOsinga
approved these changes
Jul 1, 2026
DOsinga
left a comment
DOsinga
left a comment
Collaborator
There was a problem hiding this comment.
Clean, focused bug fix — Databricks serving endpoints (even Gemini-backed ones) speak the OpenAI-compatible format, so always emitting parameters is correct. Nice that the existing test was updated to cover both the plain and databricks- prefixed gemini cases. LGTM.
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 1, 2026
* main: fix: tolerate partial Responses output items (#10108) fix(databricks): always use OpenAI-compatible "parameters" for tools (#10101) fix(providers): unescape shell-escaped image paths (#10098) chore(deps-dev): bump js-yaml from 4.1.1 to 4.2.0 in /documentation (#10107) regenerate schema (#10166) chore(deps): bump actions/stale from 10.1.1 to 10.3.0 (#10050) chore(deps): bump actions/attest-build-provenance from 4.1.0 to 4.1.1 (#10049) chore(deps): bump pnpm/action-setup from 6.0.8 to 6.0.9 (#9892) Update EmpirioLabs provider display name to EmpirioLabs AI (#10126) add declarative provider support to goose-providers crate (#9992) fix(desktop): seed mac auto-update config (#10132) Update release testing instructions (#10122)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Databricks serving endpoints — including Gemini-backed ones — speak the OpenAI-compatible chat format, so tool definitions must use the
parametersfield, not Google's nativeparametersJsonSchema.The previous
is_geminibranch informat_toolsemittedparametersJsonSchemafor any model name containing "gemini" (e.g.databricks-gemini-3-pro), which the Databricks endpoint rejects. This drops the branch so all Databricks tools useparameters.Context
Split out of #9906 per @DOsinga's review feedback — this is the self-contained, unambiguous half that can land independently of the trickier
summon.rsdelegate-inheritance rework (which remains in #9906).Testing
Updated
test_format_toolsto assert the OpenAI-compatible shape;cargo test -p goose --lib format_tools, fmt, and clippy all pass.