Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review #81

Merged
merged 5 commits into from
May 26, 2020
Merged

Code Review #81

merged 5 commits into from
May 26, 2020

Commits on May 24, 2020

  1. Code Review

     - Removed obsolete `new` keywords.
     - Added types to collection and function variables.
     - Added `final` and `const` keywords.
     - Replaced `null` guards with concise `?.` and `??` operators.
     - Added missing null check on `dispose` for `FadeAnimatedTextKit`.
     - In `fade.dart`, renamed the `_RotatingTextState` class to `_FadeTextState` to be consistent with the overall pattern and avoid confusion with `_RotatingTextState` in `rotate.dart`.
    
    **Warning**:
     - Removed `onNextBeforePause` from `ColorizeAnimatedTextKit` because it was not referenced.
    awhitford committed May 24, 2020
    Configuration menu
    Copy the full SHA
    4024a29 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Renamed more internal State classes to match their counterpart Statef…

    …ul Widget name better.
    awhitford committed May 25, 2020
    Configuration menu
    Copy the full SHA
    42f4af8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a02d3d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5170144 View commit details
    Browse the repository at this point in the history
  4. More consistency. Simplified some comparison expressions, added child…

    … to some AnimatedBuilders, and added const keyword.
    awhitford committed May 25, 2020
    Configuration menu
    Copy the full SHA
    c161948 View commit details
    Browse the repository at this point in the history