Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review #81

Merged
merged 5 commits into from
May 26, 2020
Merged

Code Review #81

merged 5 commits into from
May 26, 2020

Conversation

awhitford
Copy link
Collaborator

  • Removed obsolete new keywords.
  • Added types to collection and function variables.
  • Added final and const keywords.
  • Replaced null guards with concise ?. and ?? operators.
  • Added missing null check on dispose for FadeAnimatedTextKit.
  • In fade.dart, renamed the _RotatingTextState class to _FadeTextState to be consistent with the overall pattern and avoid confusion with _RotatingTextState in rotate.dart.

Warning:

  • Removed onNextBeforePause from ColorizeAnimatedTextKit because it was not referenced.

Pull Request Process

  1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  2. Update the README.md if needed with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters.
  3. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is SemVer.
  4. You may merge the Pull Request in once you have the sign-off of one developer, or if you do not have permission to do that, you may request the second reviewer to merge it for you.

@awhitford
Code Review
4024a29 
 - Removed obsolete `new` keywords.
 - Added types to collection and function variables.
 - Added `final` and `const` keywords.
 - Replaced `null` guards with concise `?.` and `??` operators.
 - Added missing null check on `dispose` for `FadeAnimatedTextKit`.
 - In `fade.dart`, renamed the `_RotatingTextState` class to `_FadeTextState` to be consistent with the overall pattern and avoid confusion with `_RotatingTextState` in `rotate.dart`.

**Warning**:
 - Removed `onNextBeforePause` from `ColorizeAnimatedTextKit` because it was not referenced.
@codecov
Copy link

codecov bot commented May 24, 2020 •
edited
Loading

Codecov Report

Merging #81 into master will increase coverage by 5.20%.
The diff coverage is 64.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   63.24%   68.44%   +5.20%     
==========================================
  Files           7        7              
  Lines         653      561      -92     
==========================================
- Hits          413      384      -29     
+ Misses        240      177      -63
Impacted Files Coverage Δ
lib/src/typewriter.dart 50.00% <50.00%> (+2.47%) ⬆️
lib/src/typer.dart 60.27% <60.27%> (+4.97%) ⬆️
lib/src/fade.dart 63.51% <63.51%> (+6.37%) ⬆️
lib/src/rotate.dart 66.66% <66.66%> (+6.32%) ⬆️
lib/src/scale.dart 67.07% <67.07%> (+5.68%) ⬆️
lib/src/colorize.dart 79.45% <79.45%> (+6.19%) ⬆️
lib/src/text_liquid_fill.dart 97.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715541c...c161948. Read the comment docs.

aagarwal1012
aagarwal1012 reviewed May 24, 2020
View reviewed changes
lib/src/colorize.dart Outdated Show resolved Hide resolved
aagarwal1012
aagarwal1012 reviewed May 24, 2020
View reviewed changes
lib/src/scale.dart Outdated Show resolved Hide resolved
aagarwal1012
aagarwal1012 reviewed May 24, 2020
View reviewed changes
Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awhitford, I have a few comments otherwise, this PR looks good to me.

AadumKhor
AadumKhor reviewed May 25, 2020
View reviewed changes
lib/src/fade.dart Outdated
? _fadeIn.value
: _fadeOut.value,
opacity:
_fadeIn.value != 1.0 ? _fadeIn.value : _fadeOut.value,
child: Text(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awhitford Make this Text widget a child of the AnimatedBuilder and reference it using the child property given in the builder function.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@aagarwal1012
Copy link
Owner

Also, please resolve the merge conflicts.

@AadumKhor
Copy link
Collaborator

@awhitford Great work! Please do a squash merge.

@aagarwal1012 aagarwal1012 merged commit 425c3ef into aagarwal1012:master May 26, 2020
@aagarwal1012
Copy link
Owner

@awhitford, I have sent you a collaborator invite to this repo. Great work, hope to see more contributions from you.

@allcontributors allcontributors bot mentioned this pull request May 26, 2020
Closed
Repository owner deleted a comment from allcontributors bot May 26, 2020
@aagarwal1012
Copy link
Owner

@allcontributors add @awhitford for Ideas & Planning and Maintenance.

@allcontributors allcontributors bot mentioned this pull request May 26, 2020
Merged
@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @awhitford! 🎉

@awhitford awhitford deleted the codeReview200524 branch May 27, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagarwal1012 aagarwal1012 aagarwal1012 left review comments

@AadumKhor AadumKhor AadumKhor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awhitford @aagarwal1012 @AadumKhor