Skip to content

UN-2236 [FEAT] Add build-time PostHog control for on-prem deployments #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
athul-rs merged 3 commits into from
Oct 28, 2025
Merged

UN-2236 [FEAT] Add build-time PostHog control for on-prem deployments #1615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb02f70
UN-2236 [FEAT] Add build-time PostHog control for on-prem deployments
athul-rs Oct 28, 2025
75c228f
Merge branch 'main' into UN-2236-disable-posthog-onprem
athul-rs Oct 28, 2025
5351e27
Merge branch 'main' into UN-2236-disable-posthog-onprem
athul-rs Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker/dockerfiles/frontend.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ CMD ["npm", "start"]
### FOR PRODUCTION ###
# Builder stage for production build
FROM base AS builder
ARG REACT_APP_ENABLE_POSTHOG=true
ENV REACT_APP_BACKEND_URL=""
ENV REACT_APP_ENABLE_POSTHOG=${REACT_APP_ENABLE_POSTHOG}

# Copy package files and install dependencies
COPY ${BUILD_CONTEXT_PATH}/package.json ${BUILD_CONTEXT_PATH}/package-lock.json ./
Expand Down
4 changes: 4 additions & 0 deletions frontend/sample.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
REACT_APP_BACKEND_URL=http://localhost:8000

# Analytics - PostHog (set to false to disable tracking)
# Default: false for local development
REACT_APP_ENABLE_POSTHOG=false
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REACT_APP_ENABLE_POSTHOG=false
REACT_APP_ENABLE_POSTHOG=true

@athul-rs the current change would imply that OSS users who are trying the platform will not be tracked in Posthog. Is that fine / expected? We should leave this env as true if we wish to continue to track the OSS user's behaviour
cc: @hari-kuriakose @jaseemjaskp

Copy link
Contributor

@ritwik-g ritwik-g Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrasekharan-zipstack I think your analysis might be incorrect. Since OSS users use it through containers and we are adding it as true during build time https://github.com/Zipstack/unstract/pull/1615/files#diff-7273696816af1540ab5f0d5b11c273aa396c0615b1eb25af83199637750baeb1R26 it should work as expcected


# For development
NODE_ENV=development
# Enable file watching via polling instead of filesystem events
Expand Down