Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker/dockerfiles/frontend.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ CMD ["npm", "start"]
### FOR PRODUCTION ###
# Builder stage for production build
FROM base AS builder
ARG REACT_APP_ENABLE_POSTHOG=true
ENV REACT_APP_BACKEND_URL=""
ENV REACT_APP_ENABLE_POSTHOG=${REACT_APP_ENABLE_POSTHOG}

# Copy package files and install dependencies
COPY ${BUILD_CONTEXT_PATH}/package.json ${BUILD_CONTEXT_PATH}/package-lock.json ./
Expand Down
4 changes: 4 additions & 0 deletions frontend/sample.env
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
REACT_APP_BACKEND_URL=http://localhost:8000

# Analytics - PostHog (set to false to disable tracking)
# Default: false for local development
REACT_APP_ENABLE_POSTHOG=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REACT_APP_ENABLE_POSTHOG=false
REACT_APP_ENABLE_POSTHOG=true

@athul-rs the current change would imply that OSS users who are trying the platform will not be tracked in Posthog. Is that fine / expected? We should leave this env as true if we wish to continue to track the OSS user's behaviour
cc: @hari-kuriakose @jaseemjaskp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrasekharan-zipstack I think your analysis might be incorrect. Since OSS users use it through containers and we are adding it as true during build time https://github.com/Zipstack/unstract/pull/1615/files#diff-7273696816af1540ab5f0d5b11c273aa396c0615b1eb25af83199637750baeb1R26 it should work as expcected


# For development
NODE_ENV=development
# Enable file watching via polling instead of filesystem events
Expand Down