Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 12: basic support for c-lightning-REST and Spark #994

Closed
wants to merge 4 commits into from

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented May 21, 2022

Description

Basic BOLT 12 support. No recurring options rigged up yet.

Screenshot_1653105071

  • Generate an offer (basic options)
  • Display your offers
  • Display single offer
  • Disable an offer
  • Detect if user has experimental-offers enabled, warn them if the do not + hide Offers view
  • Display extended (decoded) offer info on single offer view
  • Generate an offer (full options)
  • Decoding with bolt12 npm package
  • Fetching invoice with options provided to user based on decoded values
  • Icon for Offers on Settings view

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Other

Checklist

  • I’ve run npm run tsc and made sure my code compiles correctly
  • I’ve run npm run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run npm run prettier and made sure my code is formatted correctly
  • I’ve run npm run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND
  • c-lightning-REST
  • spark
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run npm install after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the bolt12 branch 2 times, most recently from af47c24 to 6730f26 Compare May 22, 2022 02:10
@kaloudis
Copy link
Contributor Author

Closing in favor of #2207

@kaloudis kaloudis closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant