Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-lightning-REST: bolt12 support #890

Closed
kaloudis opened this issue Mar 11, 2022 · 12 comments
Closed

c-lightning-REST: bolt12 support #890

kaloudis opened this issue Mar 11, 2022 · 12 comments
Assignees
Labels
Core Lightning Issues specific to Core Lightning Feature request New feature request Invoices

Comments

@kaloudis
Copy link
Contributor

kaloudis commented Mar 11, 2022

@kaloudis
Copy link
Contributor Author

Could be a good reference: Ride-The-Lightning/RTL#834

@Bosch-0
Copy link
Contributor

Bosch-0 commented Mar 11, 2022

There is a lot of extra user benefits that BOLT12 can offer, should we just start with simply being able to generate one and later expand on all the different functionalities like subscriptions, sending invoices etc.?

@kaloudis
Copy link
Contributor Author

Out the gate we'll let users generate offers and subscriptions with all of the params you can use on c-lightning via CLI today as c-lightning-REST has exposed them. We'll also have support to pay them and return paid and generated invoices in Activity.

We just won't have the subscription management pane set up. At the very least we need to try to encourage the implementations to do the storage of subscriptions on their layer. It would be a poor experience having one set of subscriptions in RtL, for example, and another in Zeus.

@Bosch-0 Bosch-0 added Feature request New feature request Core Lightning Issues specific to Core Lightning labels Mar 14, 2022
@Bosch-0
Copy link
Contributor

Bosch-0 commented Apr 5, 2022

Moved below content from issue #526 which was a duplicate of this.

https://github.com/Ride-The-Lightning/c-lightning-REST/pull/67/files

@kaloudis
The biggest issue is that c-lightning doesn't currently store your subscriptions, it has to be handled at the app layer. This could be annoying if you are using multiple interfaces to manage your node, eg. Zeus + RtL

@tukac
I can't connect to REST even after RTL is stopped and c-lightning restarted (using same REST port as RTL). I tried http+onion, https+onion and https+clearnet (my c-lightning uses both) but no success. What is correct approach?

edit: useful feature would be QR code scanner as option to enter text in fields, text scanner is sweet though :)

@Bosch-0 Bosch-0 moved this to Backlog in ⭐ Hermes - Zeus v0.7.0 Apr 14, 2022
@Bosch-0 Bosch-0 moved this from Backlog to To do in ⭐ Hermes - Zeus v0.7.0 Apr 14, 2022
@Bosch-0 Bosch-0 self-assigned this Apr 14, 2022
@Sjors
Copy link

Sjors commented May 23, 2022

The easiest place to start might be to just scan and pay them.

Ideally it should also warn the user that experimental-offers is not enabled, if they scan a bolt12 invoice.

@kaloudis
Copy link
Contributor Author

Work is underway here: #994

Got a great foundation but there's still a bunch left to do. Tried to document it all in the TODO list

@Bosch-0 Bosch-0 moved this from To do to In Progress in ⭐ Hermes - Zeus v0.7.0 May 25, 2022
@AndySchroder
Copy link

Definitely interested in the blinded paths portion of BOLT12. Also, would like to use the refund/withdrawal offers to make a lightning version of the Bitcoin Fluid Dispenser (http://andyschroder.com/BitcoinFluidDispenser/2.3/) and a non-micropayments version of Distributed Charge (http://andyschroder.com/DistributedCharge/).

@newtonick
Copy link
Contributor

Would be awesome to “just” pay a bolt12 offer as an intermediate step

@Sjors
Copy link

Sjors commented Jul 15, 2024

I guess this should be reopened as bolt12 support for CLNRest?

@kaloudis
Copy link
Contributor Author

I guess this should be reopened as bolt12 support for CLNRest?

CLNRest also supports BOLT 12 in v0.9.0

@Sjors
Copy link

Sjors commented Jul 17, 2024

Indeed I noticed the offer list.

@kaloudis
Copy link
Contributor Author

kaloudis commented Aug 5, 2024

Added in v0.8.5

@kaloudis kaloudis closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Lightning Issues specific to Core Lightning Feature request New feature request Invoices
Projects
None yet
Development

No branches or pull requests

5 participants