-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Replace react-native-camera-kit
with react-native-vision-camera
#1671
Conversation
After merging the branch for updating react-native to 0.72.4 I get another error:
Seems like the vision-camera and barcode-scanner libs are too new and there are still problems to be fixed. We should wait until the libs are stable. The current QR code scanner lib has issues but mostly works, also for dense QR codes if the camera is close enough. |
381f3d2
to
2473cdc
Compare
react-native-vision-camera now can scan QR codes without additional libraries. Unfortunately it crashes sometimes when closing the camera (mrousavy/react-native-vision-camera#2147). Waiting for a new release to finish this. |
2473cdc
to
3415d9c
Compare
3415d9c
to
8b69f91
Compare
8b69f91
to
f74218f
Compare
f74218f
to
ae6b3b7
Compare
ae6b3b7
to
0ebe5cd
Compare
0ebe5cd
to
4b55de2
Compare
12f3658
to
aa18730
Compare
Fixed the problems and updated original post. |
aa18730
to
59543ca
Compare
59543ca
to
cd2a8a4
Compare
cd2a8a4
to
c8b56a4
Compare
react-native-camera-kit
with react-native-vision-camera
Description
Relates to issues: #687, #1545
Replaced react-native-camera-kit with react-native-vision-camera.
Improvements:
PR is based on #2176.
Before:
After:
Currently running run-android fails with this error:I tried several recommendations but nothing helped. Maybe a react-native update is necessary. So waiting for #1663.This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: