Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(state): Limit the retrieval of note commitment subtrees #7734

Merged
merged 10 commits into from
Oct 12, 2023
Merged

fix(state): Limit the retrieval of note commitment subtrees #7734

merged 10 commits into from
Oct 12, 2023

Commits on Oct 12, 2023

  1. Fix the combining of Sapling subtrees 

    This commit fixes a bug due to which the function `sapling_subtrees`
used to always include all subtrees from the non-finalized state without
respecting the given limit.
    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    45e2d63 View commit details
    Browse the repository at this point in the history

  2. Fix the combining of Orchard subtrees 

    This commit fixes a bug due to which the function `orchard_subtrees`
used to always include all subtrees from the non-finalized state without
respecting the given limit.
    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b69c8c3 View commit details
    Browse the repository at this point in the history

  3. Add additional checks when retrieving subtrees

    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6b4f1eb View commit details
    Browse the repository at this point in the history

  4. Allow raw subtree insertions into Chain in tests

    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    42eeffe View commit details
    Browse the repository at this point in the history

  5. Derive Default for Chain

    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e7a5684 View commit details
    Browse the repository at this point in the history

  6. Derive Default for note commitment tree nodes

    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8024091 View commit details
    Browse the repository at this point in the history

  7. Use pub(super) for DiskWriteBatch 

    Set the visibility of `DiskWriteBatch` to `pub(super)`.
    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a5d6937 View commit details
    Browse the repository at this point in the history

  8. Add tests for retrieving subtrees

    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3adf6bf View commit details
    Browse the repository at this point in the history

  9. Use default() for subtree roots in tests 

    This change is unrelated to the PR.
    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    77fe471 View commit details
    Browse the repository at this point in the history

  10. Refactor docs for inserting subtrees 

    This change is unrelated to the PR.
    @upbqdn
    upbqdn committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d251e7b View commit details
    Browse the repository at this point in the history