-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(state): Limit the retrieval of note commitment subtrees #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug due to which the function `sapling_subtrees` used to always include all subtrees from the non-finalized state without respecting the given limit.
This commit fixes a bug due to which the function `orchard_subtrees` used to always include all subtrees from the non-finalized state without respecting the given limit.
Set the visibility of `DiskWriteBatch` to `pub(super)`.
This change is unrelated to the PR.
This change is unrelated to the PR.
upbqdn
added
C-bug
Category: This is a bug
A-consensus
Area: Consensus rule updates
P-Medium ⚡
I-integration-fail
Continuous integration fails, including build and test failures
I-invalid-data
Zebra relies on invalid or untrusted data, or sends invalid data
A-state
Area: State / database changes
labels
Oct 12, 2023
arya2
reviewed
Oct 12, 2023
arya2
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-consensus
Area: Consensus rule updates
A-state
Area: State / database changes
C-bug
Category: This is a bug
I-integration-fail
Continuous integration fails, including build and test failures
I-invalid-data
Zebra relies on invalid or untrusted data, or sends invalid data
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #7708.
The issue in #7708 was that when retrieving the subtrees from the finalized and non-finalized state, we always added all subtrees from the non-finalized state to the response without paying attention to the requested limit.
Solution
Default
forChain
.Default
for Sapling & Orchard note commitment treeNode
.Chain
for tests.DiskWriteBatch
topub(super)
.Unrelated Clean-ups
default()
for subtree roots in other tests.Reviewer Checklist