Repository navigation
fix(web): make WSL settings searchable #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0209d16
fix(web):-make-WSL-settings-searchable
UtkarshUsername 12c7c56
fix(web):windows-only-WSL-settings-search
UtkarshUsername 44f10c3
fix(web):hide-unavailable-WSL-search-result
UtkarshUsername d59e791
fix(web):show-WSL-search-on-load-error
UtkarshUsername 47998f6
fix(web):refresh-WSL-search-on-load-error
UtkarshUsername b812c87
fix(web):avoid-stale-WSL-search-target
UtkarshUsername 1419c14
fix(web):share-WSL-row-visibility-rule
UtkarshUsername ae02145
fix(web):clamp-settings-search-selection
UtkarshUsername dde319e
fix(web): preserve endpoint helper typing
Zain-Repo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the asynchronous WSL query inserts or removes its search item, clamping only the numeric index can silently select a different setting. For example, with the broad query
e, if “Archived threads” is selected while WSL is absent, inserting “WSL backend” immediately before it leaves the index unchanged but makes WSL active, so pressing Enter opens the wrong setting. Preserve the active result by ID or reset the selection when result identities or ordering change.Useful? React with 👍 / 👎.