fix(web): make WSL settings searchable - #17
Conversation
|
@codex review Please review the latest commits for platform filtering, WSL row visibility, stale search targets, and missing validation. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
vouch:trusted
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae0214582a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| useEffect(() => { | ||
| setActiveResultIndex((index) => Math.min(index, Math.max(results.length - 1, 0))); | ||
| }, [results.length]); |
There was a problem hiding this comment.
When the asynchronous WSL query inserts or removes its search item, clamping only the numeric index can silently select a different setting. For example, with the broad query e, if “Archived threads” is selected while WSL is absent, inserting “WSL backend” immediately before it leaves the index unchanged but makes WSL active, so pressing Enter opens the wrong setting. Preserve the active result by ID or reset the selection when result identities or ordering change.
Useful? React with 👍 / 👎.
|
Addressed the failed CI typecheck by restoring the existing AdvertisedEndpoint type import required by the merged endpoint helpers. Please review the new head. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
What changed\n- Register the WSL backend in Settings search with desktop/Windows filtering.\n- Keep search targets aligned with live WSL row visibility, including load errors and state changes.\n- Clamp keyboard selection when the result list changes.\n\nReviewed against upstream PR #8881: https://github.com/pingdotgg/t3code/pull/8881\n\nValidation: targeted settings search and Connections logic tests pass (13 tests).