This repository has been archived by the owner on Jan 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing typings-tester in favour of tsd
tsd
proved to be useful to our needs in gutenpress, but also we've lost some of the power we had by just defining comments, as we can't combine multiple assertions in the same expression.e.g.
This is the case since
expectError
doesn't return whatever it gets, rather it returnsvoid
:THence this issue closes #22, but we might want to keep an eye out for better suiting alternatives.
Improving types of
fromEntries
andmapObejct
As an extra, we're improving the types for
fromEntries
in@gutenpress/helpers
by removing the need to explicitly define the return type, and by being smarter about the returned values. Consequently, we also fixmapObject
's types as described in #21, so this issue also closes #21.