Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-4059] - Upgrade to ruby 3.2.3 #2

Merged
merged 5 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
FROM public.ecr.aws/docker/library/ruby:3.2.3-alpine3.19

RUN apk add --no-cache --update git build-base bash


RUN echo "#!/bin/sh" >> /entrypoint.sh && \
echo 'exec "$@"' >>/entrypoint.sh && \
chmod +x /entrypoint.sh
COPY signature.gemspec Gemfile Gemfile.lock /app/
COPY lib/signature/version.rb /app/lib/signature/

WORKDIR /app

RUN gem update --system 3.3.26
RUN gem install bundler:2.4.22

RUN bundle install

COPY . /app/

ENTRYPOINT ["/bin/sh", "/entrypoint.sh"]
30 changes: 19 additions & 11 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,33 +1,41 @@
PATH
remote: .
specs:
signature (0.1.8)
signature (0.1.9)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this wasn't set to a version that matched the lib/signature/version.rb one already.

On that subject, I see that you appear to have pushed a pre-release version as 1.0.0.... I think I'd probably go with 0.2.0 for this, since it doesn't seem like it actually has any compatibility-breaking changes? (Not that it matters too much, since we're the only consumers of this version of the gem.)


GEM
remote: https://rubygems.org/
specs:
bacon (1.2.0)
diff-lcs (1.2.4)
diff-lcs (1.5.1)
em-spec (0.2.6)
bacon
eventmachine
rspec (> 2.6.0)
test-unit
eventmachine (1.0.7)
rspec (2.13.0)
rspec-core (~> 2.13.0)
rspec-expectations (~> 2.13.0)
rspec-mocks (~> 2.13.0)
rspec-core (2.13.1)
rspec-expectations (2.13.0)
diff-lcs (>= 1.1.3, < 2.0)
rspec-mocks (2.13.1)
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.0)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.0)
test-unit (2.5.4)

PLATFORMS
ruby

DEPENDENCIES
em-spec
rspec
rspec (~> 3.13.0)
signature!

BUNDLED WITH
2.4.22
16 changes: 16 additions & 0 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
version: '3.5'

services:
signature:
stdin_open: true
build:
dockerfile: Dockerfile
context: .
volumes:
- .:/app
command: "bash -c 'while true; do sleep 2; done'"
logging: &default-logging-options
driver: json-file
options:
max-size: "20m"
max-file: "5"
2 changes: 1 addition & 1 deletion signature.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ Gem::Specification.new do |s|
s.require_paths = ["lib"]

s.add_dependency "jruby-openssl" if defined?(JRUBY_VERSION)
s.add_development_dependency "rspec"
s.add_development_dependency "rspec", "~> 3.13.0"
s.add_development_dependency "em-spec"
end
Loading