[WOR-4059] - Upgrade to ruby 3.2.3 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade rspec gem and fix specs - Dockerfile and docker compose
added 2 commits
February 15, 2024 10:10
dleeman
approved these changes
Feb 19, 2024
Gemfile.lock
Outdated
| @@ -1,33 +1,41 @@ | |||
| PATH | |||
| remote: . | |||
| specs: | |||
| signature (0.1.8) | |||
| signature (0.1.9) | |||
There was a problem hiding this comment.
Weird that this wasn't set to a version that matched the lib/signature/version.rb one already.
On that subject, I see that you appear to have pushed a pre-release version as 1.0.0.... I think I'd probably go with 0.2.0 for this, since it doesn't seem like it actually has any compatibility-breaking changes? (Not that it matters too much, since we're the only consumers of this version of the gem.)
AMathews
approved these changes
Feb 19, 2024
Gemfile.lock
Outdated
| @@ -1,33 +1,41 @@ | |||
| PATH | |||
| remote: . | |||
| specs: | |||
| signature (0.1.8) | |||
| signature (1.0.0) | |||
There was a problem hiding this comment.
Cleanup: Gemfile.lock didn't get updated after you changed the version number from Dylan's comment. You'll need to run bundle lock again and push up the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wfspearson.atlassian.net/browse/WOR-4059
This PR upgrades the rspec version (latest). I didn’t see a reason to not to go to latest version but I did had to upgrade it since ruby don’t implement the method
exists?anymore. The specs were updated to work with the newest rspec.I also added a Dockerfile and docker-compose because I had issues installing
eventmachine v1.0.7natively (I believe this has something to do with my M1 Sonoma MacOS since it works without any issues in ruby:3.2.3-alpine3.19 docker image).I don’t think the docker is 100% necessary but this is the way I found to be able to run the tests locally.
Tests passing:
