Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github packages for private gem registry [IN-181] #1

Merged
merged 1 commit into from
Sep 11, 2022
+4 −1
Merged

Use Github packages for private gem registry [IN-181] #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/signature/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Signature
VERSION = "0.1.8"
VERSION = "0.1.9"
end
3 changes: 3 additions & 0 deletions signature.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ Gem::Specification.new do |s|
s.summary = %q{Simple key/secret based authentication for apis}
s.description = %q{Simple key/secret based authentication for apis}


s.metadata['allowed_push_host'] = "https://rubygems.pkg.github.com/YourAcclaim"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why the same check isn't being done here as the other repos like: https://github.com/YourAcclaim/s3_image_processor/pull/1/files#diff-7aa6a00cdd54637ce521768ec7bded9f062fb2c935783d81821bb80c2b6f4c64R18-R22

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason is that this repo is public, whereas the others are not. So the impact to our organization if this were accidentally pushed to a public registry is lower. (There's also an already-published version of this gem in RubyGems, which we don't have keys to push to, which makes it very unlikely we'd accidentally push it to the wrong host.)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Thanks for pointing that out.


s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
Expand Down