Use Github packages for private gem registry [IN-181] #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated gemspec to specify Github RubyGems package registry as allowed push host and updated gem version to reflect the change
rmCredly
approved these changes
Aug 22, 2022
| @@ -12,6 +12,9 @@ Gem::Specification.new do |s| | |||
| s.summary = %q{Simple key/secret based authentication for apis} | |||
| s.description = %q{Simple key/secret based authentication for apis} | |||
|
|
|||
|
|
|||
| s.metadata['allowed_push_host'] = "https://rubygems.pkg.github.com/YourAcclaim" | |||
There was a problem hiding this comment.
Curious why the same check isn't being done here as the other repos like: https://github.com/YourAcclaim/s3_image_processor/pull/1/files#diff-7aa6a00cdd54637ce521768ec7bded9f062fb2c935783d81821bb80c2b6f4c64R18-R22
There was a problem hiding this comment.
The main reason is that this repo is public, whereas the others are not. So the impact to our organization if this were accidentally pushed to a public registry is lower. (There's also an already-published version of this gem in RubyGems, which we don't have keys to push to, which makes it very unlikely we'd accidentally push it to the wrong host.)
There was a problem hiding this comment.
Ah I see. Thanks for pointing that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updates the gemspec to target this repo's Github package registry. Version updated to reflect both the update to the gemspec, but also I suppose the earlier update to handle nested hashes/arrays.