sim: Make cycle width small as possible and configurable #5430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we keep the default the same? |
|
@jix Then it would require a way for a width to be defined and propagated from sby, and for that I was not sure on how many places it is actually used |
|
I consider changing the default a significant regression, since this makes correlating timestamps and cycle counts require mental arithmetic which wasn't required before (very simple arithmetic, but still distracting when debugging a complicated FV failure). I'll look into adding an option for this to SBY. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default size is made 2 since number must be even since we do add half cycle size on some places.
Since one test case did utilize time as well, needed to update it.