pyosys generator: ignore attributes #4701
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
log_error
,log_file_error
andlog_cmd_error
which are all marked[[noreturn]]
to be wrapped.The corresponding diff to the generated c++ is
Note that although all 3 of these commands are added,
log_cmd_error
shouldn't be used from python for now as in interactive mode it throwslog_cmd_error_exception
, expecting the main shell loop to catch it but this exception can't be passed through python so it causes python to throw its own exception. I'm not 100% sure how best to translate this exception so haven't bothered for now