Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use view binding instead of findViewById #475

Merged
merged 12 commits into from
Feb 5, 2025
+525 −425
Merged

Use view binding instead of findViewById #475

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5587b8e
Use view binding instead of findViewById
chrgernoe Jan 14, 2025
81fa98a
Remove obsolete LinearLayout in privacy policy activity
chrgernoe Jan 16, 2025
6b80f7b
Fix layout of ascend activity after mirgration to view binding
chrgernoe Jan 16, 2025
b4ad892
Use DialogWidgetBuilder for update handler dialog
chrgernoe Jan 19, 2025
349b367
Remove obsolete title from year picker dialog.
chrgernoe Jan 19, 2025
9334c72
Use DialogWidgetBuilder for rock and route search dialog
chrgernoe Jan 23, 2025
274cd53
Improve coding style in classes RockSearchable and RouteSearchable
chrgernoe Jan 23, 2025
9bf6799
Rename activity view binding property
chrgernoe Jan 23, 2025
9089982
Replace findViewById in comment dialog code
chrgernoe Jan 24, 2025
f5cd638
Code clean-up
chrgernoe Jan 25, 2025
edbacb0
Fix issue with view order in comment dialog
chrgernoe Feb 4, 2025
9a7b6cc
Merge branch 'master' into ktlo/use-view-binding
chrgernoe Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix layout of ascend activity after mirgration to view binding
@chrgernoe
chrgernoe committed Jan 19, 2025
commit 6b80f7b57b4d227e64cc809f1f311862ecbdeff3
11 changes: 5 additions & 6 deletions app/src/main/res/layout/activity_ascend.xml
View file
Original file line number Diff line number Diff line change
@@ -20,17 +20,16 @@
<ScrollView
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:layout_marginTop="20dp"
android:layout_marginLeft="20dp"
android:layout_marginRight="20dp"
android:layout_height="match_parent"
android:fillViewport="true">

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical"
android:layout_marginTop="@dimen/activity_vertical_margin"
android:layout_marginLeft="@dimen/activity_horizontal_margin"
android:layout_marginRight="@dimen/activity_horizontal_margin"
android:clickable="true"
android:focusable="true"
android:focusableInTouchMode="true"
@@ -126,4 +125,4 @@

</LinearLayout>

</ScrollView>
</ScrollView>