Use view binding instead of findViewById #475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
KTLO
chrgernoe
commented
Jan 16, 2025
| @@ -20,17 +20,16 @@ | |||
| <ScrollView | |||
| xmlns:android="http://schemas.android.com/apk/res/android" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="wrap_content" | |||
There was a problem hiding this comment.
It seems to be a bug in the Android library because this layout was working with the previous implementation but with view binding the margins were not recognized anymore.
The year picker makes the title invisible
chrgernoe
force-pushed
the
ktlo/use-view-binding
branch
from
cc3cf97 to
349b367
Compare
paetz
previously approved these changes
Jan 20, 2025
app/src/main/java/com/yacgroup/yacguide/BaseNavigationActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/yacgroup/yacguide/activity_properties/AscentFilterable.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/yacgroup/yacguide/activity_properties/RockSearchable.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/yacgroup/yacguide/activity_properties/RockSearchable.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/yacgroup/yacguide/activity_properties/RockSearchable.kt
Outdated
Show resolved
Hide resolved
| @@ -152,7 +152,6 @@ | |||
| <string name="ascend_edit_date">Datum:</string> | |||
| <string name="ascend_edit_style">Stil:</string> | |||
| <string name="ascend_edit_title">Begehung bearbeiten</string> | |||
| <string name="select_year">Jahr auswählen</string> | |||
There was a problem hiding this comment.
Don't we display this anymore?
There was a problem hiding this comment.
Inflating the year picker layout into the dialog somehow overrides the complete dialog, including the title. Look good for me.
chrgernoe
force-pushed
the
ktlo/use-view-binding
branch
from
67515aa to
4cc6c5c
Compare
chrgernoe
force-pushed
the
ktlo/use-view-binding
branch
from
069b19a to
f5cd638
Compare
paetz
requested changes
Jan 30, 2025
| @@ -66,7 +67,7 @@ abstract class TableActivity : BaseNavigationActivity() { | |||
| Comment( | |||
| text = it.text.orEmpty(), | |||
| properties = listOf( | |||
| CommentProperty(R.id.qualityLayout, R.string.relevance, RegionComment.QUALITY_MAP, it.qualityId) | |||
| CommentProperty(R.string.relevance, RegionComment.QUALITY_MAP, it.qualityId) | |||
There was a problem hiding this comment.
- Please check e.g. in Zittauer Gebirge - Weißbachtal - Kleiner Grenzkogel - Alter Weg. When showing the comments dialog, the comment's text is placed above the drying info, which is a regression. Another example is Zittauer Gebirge - Weißbachtal - Kleiner Grenzkogel - Alter Weg. In the first comment, the comment's text is placed above protection, too.
Seems to be a flakiness since most comments look ok as far as I could see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View binding is has some technical advantages. See https://developer.android.com/topic/libraries/view-binding. I think also it is much clearer which element is accessed where. Search through the layout is not so easy to understand. However, there are still some code that uses
findViewByIdwhich cannot easily changed.