Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed 2.0.1-b1 #4888

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Proposed 2.0.1-b1 #4888

merged 7 commits into from
Jan 18, 2024

Conversation

intelliot
Copy link
Collaborator

High Level Overview of Change

This is a beta for the 2.0.1 hotfix release.

Highlights:

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI).

Context of Change

There is unbounded memory growth when running the path_find command. This is fixed in 2.0.1-b1 and later.

Type of Change

  • Release

API Impact

No API impact.

ximinez and others added 7 commits January 11, 2024 20:11
Prevent WebSocket connections from trying to close twice.

The issue only occurs in debug builds (assertions are disabled in
release builds, including published packages), and when the WebSocket
connections are unprivileged. The assert (and WRN log) occurs when a
client drives up the resource balance enough to be forcibly disconnected
while there are still messages pending to be sent.

Thanks to @lathanbritz for discovering this issue in XRPLF#4822.
…away memory usage: (XRPLF#4822)

* Add logging for Application.cpp sweep()
* Improve lifetime management of ledger objects (`SLE`s)
* Only store SLE digest in CachedView; get SLEs from CachedSLEs
* Also force release of last ledger used for path finding if there are
  no path finding requests to process
* Count more ST objects (derive from `CountedObject`)
* Track CachedView stats in CountedObjects
* Rename the CachedView counters
* Fix the scope of the digest lookup lock

Before this patch, if you asked "is it caching?" It was always caching.
Resolves a warning that was emitted from the clang compiler. Switches
usage of the sprintf function to the recommended snprintf function.

Warning was observed in Apple clang version 15.0.0 (clang-1500.0.40.1).

Fix XRPLF#4569
Clients subscribed to `transactions` over WebSocket are being
disconnected because the traffic exceeds the default `send_queue_limit`
of 100.

This commit changes the default configuration, not the default in code.

Fix XRPLF#4866
Minor change in unit tests to improve testing scope.
@intelliot intelliot merged commit 87ee786 into XRPLF:release Jan 18, 2024
16 checks passed
@intelliot intelliot deleted the develop-next branch January 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants