PR Template - add Type of Change: Performance
#4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliot
requested review from
mtrippled,
sophiax851,
Bronek,
scottschurr and
ckeshava
and removed request for
mtrippled
ckeshava
approved these changes
Jan 11, 2024
intelliot
added
the
Perf impact not expected
|
ok for 2.0.1: only touches a markdown file - no code change. |
sophiax851
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Some PRs aim to improve performance. Other PRs impact performance, either positively or negatively. Other PRs are expected to have some unknown impact. In all of these cases, it would be helpful to have a
Type of Changecheckbox for "Performance".Context of Change
Other PRs have already added this checkbox. By adding it to the template, PR authors will be reminded that such changes should be explicitly called out and described. Additionally, there are four questions that the RippleX Performance Team has requested answers for:
These details should be provided for all PRs that the Perf team should pay attention to.
Type of Change
.gitignore, formatting, dropping support for older tooling)