Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-15628 Add default timeout to waitForElementToBeRemoved #34

Merged
merged 6 commits into from
Sep 21, 2021
Merged

CPLAT-15628 Add default timeout to waitForElementToBeRemoved #34

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53492c3
Add default duration to timeout
brianphillips-wk Sep 17, 2021
f936d2f
Use asyncUtilTimeout for timeout duration
brianphillips-wk Sep 17, 2021
ea2cead
Add sanity check for timeout duration fix
brianphillips-wk Sep 17, 2021
48dcb8c
Update test to check for wait_for default value
brianphillips-wk Sep 20, 2021
f722c08
Merge branch 'master' into add_duration_waitForElementToBeRemoved
brianphillips-wk Sep 21, 2021
2e8c3d7
Format
brianphillips-wk Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/dom/async/wait_for.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Future<T> waitFor<T>(
Future<void> waitForElementToBeRemoved(
Node Function() callback, {
Node container,
Duration timeout,
Duration timeout = const Duration(seconds: 1),
brianphillips-wk marked this conversation as resolved.
Show resolved Hide resolved
brianphillips-wk marked this conversation as resolved.
Show resolved Hide resolved
Duration interval = const Duration(milliseconds: 50),
QueryTimeoutFn onTimeout,
MutationObserverOptions mutationObserverOptions = defaultMutationObserverOptions,
Expand Down