CPLAT-15628 Add default timeout to waitForElementToBeRemoved #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
test/unit/dom/wait_for_test.dart
Outdated
Comment on lines
209
to
216
| test('an element that is never removed, throws with default timeout value', () async { | ||
| expect( | ||
| () => rtl.waitForElementToBeRemoved(() => elementThatWontBeRemoved, container: view.container), | ||
| throwsA(allOf( | ||
| isA<TimeoutException>(), | ||
| hasToStringValue(contains('The element returned from the callback was still present in the container after ${asyncQueryTimeout.inMilliseconds}ms:')), | ||
| ))); | ||
| }, timeout: asyncQueryTestTimeout); |
There was a problem hiding this comment.
Alrighty folks, this test should do the trick. As @sydneyjodon-wk suggested, I'm testing against an element that is never removed. Fails without the default value set (Cannot read properties of null), passes when default is set 👍
I removed my previous test—looks like the test on line 174 already handles that case.
brianphillips-wk
dismissed stale reviews from joebingham-wk and sydneyjodon-wk
via
2e8c3d7
sydneyjodon-wk
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
waitForElementToBeRemoveddoesn’t have a default for timeout. Though it calls waitFor (which has a default timeout), it throws its own timeout exception which uses waitFor's duration in the message.For more info, see this Slack thread.
Changes
Durationto thetimeoutparameterRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: