Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIP-2309: Set up travis and codecov for OSS #2

Merged
merged 5 commits into from
May 22, 2017
Merged

UIP-2309: Set up travis and codecov for OSS #2

merged 5 commits into from
May 22, 2017

Conversation

jacehensley-wf
Copy link
Contributor

@jacehensley-wf jacehensley-wf commented May 5, 2017 •
edited
Loading

  • Add .travis.yml and .codecov.yml files
  • No longer run tests on smithy.
  • Add license and notice files

FYA: @aaronlademann-wf @greglittlefield-wf @clairesarsam-wf @joelleibow-wf @kaanaksoy-wk

@aviary-wf
Copy link

Raven

Number of Findings: 0

@rmconsole-wf
Copy link

rmconsole-wf commented May 5, 2017 •
edited
Loading

General Information

Ticket(s):

Code Review(s): #2

Additional Information

Reviewers: joelleibow-wf, greglittlefield-wf, aaronlademann-wf
Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: ui_test_utils 0.0.1
	Release Ticket(s): UIP-1357

Last updated on Monday, May 22 11:10 AM CST

greglittlefield-wf
greglittlefield-wf reviewed May 5, 2017
View reviewed changes
LICENSE Outdated
@@ -0,0 +1,13 @@
Copyright 2016 Workiva Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017**

greglittlefield-wf
greglittlefield-wf reviewed May 5, 2017
View reviewed changes
NOTICE Outdated
@@ -0,0 +1,14 @@
over_react_test
Copyright 2015 Workiva Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017**

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We should update the over_react ones too.

@aaronlademann-wf
Copy link
Contributor

+1

1 similar comment
@greglittlefield-wf
Copy link
Contributor

+1

@jacehensley-wf jacehensley-wf changed the title Set up travis and codecov for OSS UIP-2309: Set up travis and codecov for OSS May 22, 2017
@joelleibow-wf
Copy link
Contributor

QA +1

@joelleibow-wf joelleibow-wf merged commit bea629d into Workiva:master May 22, 2017
@sourcegraph-wk sourcegraph-wk mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf left review comments

Assignees
No one assigned
Labels
Merge Requirements Met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacehensley-wf @aviary-wf @rmconsole-wf @aaronlademann-wf @greglittlefield-wf @joelleibow-wf