Update OverReact syntax to support Dart 2.9+ #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to enable Workiva to transition to Dart >=2.9.0 with ease, a slight update to OverReact factory syntax
is required.
Important:
is the reference for OverReact snippets.
core check will fail if the incompatible mixin based boilerplate is introduced again to a project that has migrated already.
NOTE: Only the mixin based boilerplate factories will be migrated. In other words, if your factory is still
using the
@Factory
annotation, it will not be migrated to the Dart 2.9-compatible boilerplate and must firstbe migrated to the mixin based syntax.
For additional reference, here
are the instructions to migrate for projects depedent on Web Skin Dart.
Changes
Below are two examples of the minor tweaks that will occur. For a reference of all the small changes that will occur
(including to the
connect
syntax), refer to option #2 here.Note that
ignore
comments are not included in those examples.Release Notes
Migrate mixin based factories to the Dart 2.9-compatible boilerplate.
QA
These changes are not expected to require any special form of QA. As long as CI performs analysis on Dart code and runs a Dart build,
a passing CI is sufficient to merge these changes.
For more information or questions, reach out to us in the #support-ui-platform Slack channel.
Created by Sourcegraph campaign
Workiva/dart2_9_boilerplate_migration
.