UIP-2413: Get tests passing with the DDC #86
Conversation
RavenNumber of Findings: 0 |
| domClassMirror = reflectClass(Dom); | ||
|
|
||
| // staticMembers is not implemented for the DDC and will throw is this test is loaded even if it's not run. | ||
| try { |
There was a problem hiding this comment.
We shouldn't need this try-catch, then, if it's not run in the DDC, right?
There was a problem hiding this comment.
It throws even if the test isn't run 😢
There was a problem hiding this comment.
Wait, the contents of setUpAll are evaluated even when the group is disabled? Is that a test package bug?
There was a problem hiding this comment.
I don't know if it's evaluated, I think the DDC might just be checking for instances of that being used, because it throws if it's in a test too
There was a problem hiding this comment.
But if I use skip: it's fine. So maybe it is a test package bug.
| @@ -57,5 +62,5 @@ main() { | |||
| expect(component.type, equalsIgnoringCase(expectedTagName)); | |||
| }); | |||
| } | |||
| }); | |||
| }, tags: 'no-ddc'); | |||
There was a problem hiding this comment.
Why is this disabled in the DDC? Should have a comment
There was a problem hiding this comment.
Can't use staticMethod. I'll add a comment
There was a problem hiding this comment.
Hm, we should really still test these in the DDC if possible.
What about if we enumerated these, and just checked them against the reflected values, like so?
const expectedStaticMethods = const <Symbol> [#div, #span, ...];
var actualMethods;
try {
actualMethods = domClassMirror.staticMembers.values.map((m) => m.simpleName).toList();
} catch(e) {}
if (actualMethods != null) {
expect(actualMethods, unorderedEquals(expectedStaticMethods),
reason: '`expectedStaticMethods` needs to be updated');
}
for (var method in expectedStaticMethods) {
String name = MirrorSystem.getName(method);
...| @@ -437,6 +437,6 @@ void main() { | |||
|
|
|||
| group('common component functionality:', () { | |||
| commonComponentTests(ResizeSensor); | |||
| }); | |||
| }, tags: 'no-ddc'); | |||
There was a problem hiding this comment.
Why is this disabled in the DDC? Should have a comment
There was a problem hiding this comment.
Can't use instanceMembers in the DDC. I'll add a comment
| @@ -126,7 +126,7 @@ void mapProxyTests(Map mapProxyFactory(Map proxiedMap)) { | |||
| expect(proxy.values, equals(['value'])); | |||
| verify(mock.values); | |||
| }); | |||
| }); | |||
| }, tags: 'no-ddc'); | |||
There was a problem hiding this comment.
Why is this disabled in the DDC? Should have a comment
There was a problem hiding this comment.
Mocks don't work in the DDC. I'll add a comment
| @@ -73,7 +73,7 @@ main() { | |||
| expect(syntheticKeyboardEvent.metaKey, isFalse); | |||
| expect(syntheticKeyboardEvent.repeat, isFalse); | |||
| expect(syntheticKeyboardEvent.shiftKey, isFalse); | |||
| }); | |||
| }, tags: 'no-ddc'); | |||
There was a problem hiding this comment.
Why is this disabled in the DDC? Should have a comment
| @@ -126,7 +126,7 @@ main() { | |||
| expect(syntheticMouseEvent.screenX, isNull); | |||
| expect(syntheticMouseEvent.screenY, isNull); | |||
| expect(syntheticMouseEvent.shiftKey, isFalse); | |||
| }); | |||
| }, tags: 'no-ddc'); | |||
There was a problem hiding this comment.
Why is this disabled in the DDC? Should have a comment
UIP-2413
| @@ -22,12 +22,6 @@ import '../../../test_util/test_util.dart'; | |||
|
|
|||
| main() { | |||
| group('transformed component integration:', () { | |||
| test('props class cannot be instantiated directly', () { | |||
There was a problem hiding this comment.
Why was this test removed?
There was a problem hiding this comment.
Prop classes are made abstract by the transformer and the DDC was failing on instantiating an abstract object.
There was a problem hiding this comment.
And this test was leftover from before that was the case, so it's not really necessary anymore
UIP-2413
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 31 31
Lines 1522 1522
=======================================
Hits 1443 1443
Misses 79 79 |
aaronlademann-wf
added
State: ready for QA
Type: task
and removed
Dependent PR
State: ready for QA
labels
|
+1 |
|
+1 |
|
QA +10
Merging. |
Ultimate problem:
Tests were not passing with the DDC
How it was fixed:
Testing suggestions:
pub serve test --web-compiler=dartdevcin one terminalpub run test -p vm -p chrome -x no-ddc --pub-serve=8080 test/vm_tests/ test/over_react_component_declaration_test.dart test/over_react_component_test.dart test/over_react_util_test.dartin another terminalPotential areas of regression:
N/A