UIP-2430 Use over_react_test, rip out duplicated test utils #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
| @@ -1101,3 +1101,12 @@ class PlainObjectPropsMap { | |||
| class PlainObjectStyleMap { | |||
| external get width; | |||
| } | |||
|
|
|||
| /// Helper component that renders whatever you tell it to. Necessary for rendering components with the 'ref' prop. | |||
| final RenderingContainerComponentFactory = | |||
There was a problem hiding this comment.
This was only needed by this file, so I moved it here from test/test_util/react_util.dart
| @@ -35,7 +35,7 @@ main() { | |||
| test('root contains the other element', () { | |||
| var rootInstance = render(DomTest()); | |||
| var rootNode = findDomNode(rootInstance); | |||
| var otherNode = getDomByTestId(rootInstance, 'innerComponent'); | |||
There was a problem hiding this comment.
This was deprecated
| @@ -265,8 +265,6 @@ void testClassNameMerging(BuilderOnlyUiFactory factory, dynamic childrenFactory( | |||
| excludesClasses('blacklisted-class-1 blacklisted-class-2') | |||
| ) | |||
| )); | |||
|
|
|||
| unmount(renderedInstance); | |||
There was a problem hiding this comment.
This was being auto-unmounted, so this was unnecessary
| @@ -278,8 +276,6 @@ void testClassNameMerging(BuilderOnlyUiFactory factory, dynamic childrenFactory( | |||
| var descendantsWithCustomClass = react_test_utils.scryRenderedDOMComponentsWithClass(renderedInstance, customClass); | |||
|
|
|||
| expect(descendantsWithCustomClass, hasLength(1)); | |||
|
|
|||
| unmount(renderedInstance); | |||
There was a problem hiding this comment.
This was being auto-unmounted, so this was unnecessary
| @@ -289,7 +285,8 @@ void testClassNameOverrides(BuilderOnlyUiFactory factory, dynamic childrenFactor | |||
| var reactInstanceWithoutOverrides = render( | |||
| (factory() | |||
| ..addProp(forwardedPropBeacon, true) | |||
| )(childrenFactory()) | |||
| )(childrenFactory()), | |||
| autoTearDown: false | |||
There was a problem hiding this comment.
This was being unmounted manually later on, so this was necessary
| export 'dom_util.dart'; | ||
| export 'react_util.dart'; | ||
| export 'wrapper_component.dart'; | ||
| export 'package:over_react_test/over_react_test.dart'; |
There was a problem hiding this comment.
I just exported these instead of updating the imports in every file, in order to get this through more quickly and with less risk of merge conflicts.
rmconsole2-wf
changed the title
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 31 31
Lines 1522 1522
=======================================
Hits 1443 1443
Misses 79 79 |
+10
|
|
QA +10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
We had duplicated code for test utils that has since made its way into over_react_test.
How it was fixed:
Pull in over_react_test, rip out duplicated test utils
Testing suggestions:
ddev test -p content-shellddev test -p chromePotential areas of regression:
Tests