Drawer update#252
Merged
Merged
Conversation
* feature: type store * fix: stash issues
# Conflicts: # src/scripts/components/NoticeImage.js # src/scripts/components/NoticesArea.js # src/scripts/utils/sanitization.js
erikyo
added
the
[Scope] User Interface
johnhooks
reviewed
Apr 10, 2023
johnhooks
requested changes
Apr 10, 2023
Co-authored-by: John Hooks <bitmachina@outlook.com>
erikyo
commented
Apr 10, 2023
This was referenced Apr 11, 2023
Merged
johnhooks
previously approved these changes
Apr 12, 2023
johnhooks
requested changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a complete refresh of the drawer which is now a React component.
Why?
Previously the drawer was created by adding some html markup next to the menu during the initialization of the admin bar. This allowed us to have already in place an area where to initialize the component to display notifications (with the context of the admin-bar) but had also some drawbacks e.g. the sidebar that could not be a component.
How?
We revised and rewrote some js scripts, plugin init, added/updated components, adjusted css styling.
@johnhooks provided types and fixed some reducer related issues
Screenshots or screencast
closes #186, fix #182