feature: type redux store#9
Merged
Merged
Conversation
johnhooks
commented
Apr 7, 2023
| export const hydrate = ( payload ) => { | ||
| return { | ||
| type: 'HYDRATE', | ||
| type: /** @type {'HYDRATE'} */ ( 'HYDRATE' ), |
Collaborator
Author
There was a problem hiding this comment.
This is weird but required for it to be type 'HYDRATE' not string. Otherwise the type union in action types doesn't work right in the reducer.
| */ | ||
|
|
||
| /** | ||
| >>>>>>> Stashed changes |
Collaborator
Author
There was a problem hiding this comment.
ARGH... JUST A SEC THESE SHOULDN'T BE HERE
| /** | ||
| * List all notifications or those of a particular context | ||
| * | ||
| * @param {string|false} context |
Collaborator
Author
There was a problem hiding this comment.
The false value was never handled in the selector.
| /** | ||
| * Clear all notifications | ||
| * | ||
| * @param {string|false} context |
Collaborator
Author
There was a problem hiding this comment.
The false value was never handled in the selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type the redux store.