Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Hooks: Inject hooked blocks into modified templates and parts #5726

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Dec 4, 2023

Using the new technique of storing information about whether or not a hooked block should be considered for injection or not, extend said injection to encompass modified templates and parts.

Follow-up to #5712.

Trac ticket: https://core.trac.wordpress.org/ticket/59646


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham self-assigned this Dec 4, 2023
@ockham ockham force-pushed the update/inject-block-hooks-into-modified-templates-etc branch from cf34d15 to 20e9b2e Compare December 5, 2023 16:48
@ockham ockham force-pushed the update/inject-block-hooks-into-modified-templates-etc branch from dafeaf9 to 9a122e3 Compare January 30, 2024 09:26
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ockham ockham force-pushed the update/inject-block-hooks-into-modified-templates-etc branch from 9a122e3 to bcf555f Compare February 12, 2024 09:42
@ockham ockham marked this pull request as ready for review February 12, 2024 13:04
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bernhard-reiter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ockham
Copy link
Contributor Author

ockham commented Feb 12, 2024

This is one of the major changes planned for 6.5 and has been in the works for a while. It has been discussed quite extensively on the accompanying ticket, and most work has happened on preparatory changesets such as https://core.trac.wordpress.org/changeset/57157 and WordPress/gutenberg#58553. Unit test coverage in this PR should ensure that it works properly.

I'll commit shortly 🙂

@ockham
Copy link
Contributor Author

ockham commented Feb 12, 2024

Committed to Core in https://core.trac.wordpress.org/changeset/57594.

@ockham ockham closed this Feb 12, 2024
@ockham ockham deleted the update/inject-block-hooks-into-modified-templates-etc branch February 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant