Block Hooks: Update the compatibility layer

[ockham]

What?

Update lib/compat/wordpress-6.4/block-hooks.php to better reflect Block Hooks code as present in WP 6.4.

Why?

We've found that we might need a more faithful copy of the Block Hooks code as found in Core in order to unlock some new features, e.g. #58388. In addition, this might be a blocker to WordPress/wordpress-develop#5726.

How?

By copying code from Core, and carefully replacing existing functions with it.

Testing Instructions

TBD, but basically: Test on WP 6.3, 6.4, trunk.

Questions

What's our back-compat policy for Gutenberg? This PR is removing a number of functions, plus the gutenberg_serialize_blocks filter.

TODO

• Insertion into Comment Template block isn't working in the editor. (That's a pattern, so probably that's not working?)
• Make sure we're not missing theme attribute injection anywhere.
• Include compat layer for WP 6.5.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/block-hooks.php
❔ lib/compat/wordpress-6.4/class-gutenberg-rest-block-patterns-controller.php

[ockham]

FYI @tjcafferkey 🙂

[github-actions]

Flaky tests detected in 83bcd66.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7716025527
📝 Reported issues:

• [Flaky Test] directives inside islands should not be hydrated twice #58332 in /test/e2e/specs/interactivity/tovdom-islands.spec.ts

[ockham]

Closing. WordPress 6.5 is going to be released in less than a week, which will raise the minimum required WordPress version for Gutenberg to 6.4, making the 6.4 compat layer obsolete.