Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block supports: reinstate deprecation functions and add notice #2522

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Apr 6, 2022

In #2500 we deleted private block supports functions that are no longer used in WordPress 6.0.0.

This PR reinstates them and add deprecation notices as recommended by @peterwilsoncc over in #2500 (comment)

Trac ticket: https://core.trac.wordpress.org/ticket/55505


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@peterwilsoncc
Copy link
Contributor

@ramonjd Are you able to move these to src/wp-includes/deprecated.php?

If there are replacement functions, then you can add the new function name as a third parameter to _deprecated_function().

@ramonjd
Copy link
Member Author

ramonjd commented Apr 6, 2022

Are you able to move these to src/wp-includes/deprecated.php?

Yes! Will do. Thanks for letting me know. I wasn't aware of that file.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@peterwilsoncc
Copy link
Contributor

@gziolo
Copy link
Member

gziolo commented Apr 6, 2022

Thank you @peterwilsoncc and @ramonjd for a quick follow-up on that ❤️

src/wp-includes/deprecated.php Show resolved Hide resolved
src/wp-includes/deprecated.php Show resolved Hide resolved
src/wp-includes/deprecated.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants