Block supports: migrate spacing, border, color, dimensions, elements and typography and associated tests. #2500
Conversation
…2.9.0 to WordPress 6.0 Includes changes from WordPress/gutenberg@6de1698 Skips Style Engine integration from https://github.com/WordPress/gutenberg/commit/44925a947fde29feaab512e0adf4291272209d59`
ramonjd
changed the title
|
We already have a Trac ticket https://core.trac.wordpress.org/ticket/55505 that @hellofromtonya opened for all backporting necessary for the Gutenberg plugin. |
|
The block support serialization changes included in this PR so far (all except layout.php) look good and cover those introduced in WordPress/gutenberg#36293. I'm happy to review again once the layout.php updates are also added. |
This patch looks big already. Can we land that part separately? I could do some additional review pass in 1-2 hours and commit changes if no blockers discovered. |
| * @param WP_Block_type $block_type Block type. | ||
| * @return bool Whether to serialize spacing support styles & classes. | ||
| */ | ||
| function wp_skip_dimensions_serialization( $block_type ) { |
There was a problem hiding this comment.
@peterwilsoncc or @hellofromtonya, should we keep functions like this one with no code and depreciation notice for backward compatibility or is it fine to remove as they were marked as private?
There was a problem hiding this comment.
The practice is to move the functions to deprecated and throw a warning, for example:
wordpress-develop/src/wp-includes/deprecated.php
Lines 3373 to 3386 in 6c270d0
Unfortunately plugin authors have a habit of ignoring private access statements. To be fair, some of this is self inflicted by things such as WP_List_Table still being marked as private.
There was a problem hiding this comment.
Thanks folks! If we decide it's a good idea to reinstate them, I've thrown up a PR here: #2522
Layout over here: #2518 |
|
Committed with https://core.trac.wordpress.org/changeset/53076. |
…ordPress#2500 and adds a deprecation notice for each.
Gutenberg plugin migration to WordPress 6.0 also being tracked in WordPress/gutenberg#39889.
This diff migrates block support spacing, border, color, dimensions, elements and typography and associated tests from Gutenberg 12.9.0 to WordPress 6.0
The goal is to include the latest plugin, while skipping the Style Engine integration, which only features in
spacing.php. The Style Engine class doesn't bring any new functionality - it's more of a first iteration in a set of long-term changes.In summary:
Trac ticket: https://core.trac.wordpress.org/ticket/55505
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.